Re: [PATCH v2 1/7] dt-bindings: clock: Introduce nexus nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The clock nexus node schema omits standard nexus map properties (`clock-map-mask` and `clock-map-pass-thru`) and `#clock-cells`.
--

--- Patch [1]: [PATCH v2 1/7] dt-bindings: clock: Introduce nexus nodes ---
commit 4092325fdc1397916665dc9c21bd4330df6026ce
Author: Miquel Raynal (Schneider Electric) <miquel.raynal@bootlin.com>

dt-bindings: clock: Introduce nexus nodes

This commit introduces a new device tree binding for clock nexus nodes,
allowing hardware containers to remap clock specifier lists from consumer
nodes in a generic way. It applies the concept from existing PWM and GPIO
nexus nodes to clocks.

> diff --git a/Documentation/devicetree/bindings/clock/clock-nexus-node.yaml b/Documentation/devicetree/bindings/clock/clock-nexus-node.yaml
> new file mode 100644
> index 0000000000000..ff3283bd5fb11
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/clock-nexus-node.yaml
[ ... ]
> +properties:
> +  clock-map:
> +    $ref: /schemas/types.yaml#/definitions/uint32-matrix

[Severity: Medium]
Does this schema omit the definition for #clock-cells and the standard
nexus map properties like clock-map-mask and clock-map-pass-thru?

Without these properties defined in the properties block, there is no type
checking for clock-map-mask and clock-map-pass-thru. Furthermore, if a
consumer device tree node uses them and specifies unevaluatedProperties: false
in its own binding, could it spuriously fail schema validation during
dt_binding_check?

> +
> +dependentRequired:
> +  clock-map: ['#clock-cells']
> +
> +additionalProperties: true

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260710-schneider-v7-2-rc1-eip201-upstream-v2-0-b4680787377e@bootlin.com?part=1