From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A1B543B635A; Fri, 10 Jul 2026 21:23:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783718626; cv=none; b=RtaFkE6nOrVdB1A1xIt/OfC5fXbsxOGXteMu85LaBG5yI6/XVrZ3FcliFuD+vxlNEgqsxiDgt1tR3b9/K9h0JYOvQ8qCuiqdfsxSnkCUC+wUZ5GTzp6EA/buofh3fMkj1hbmclrOOhs7j4l0UPeCfRpL+/FTIhK8ZmGcl3aPuCM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783718626; c=relaxed/simple; bh=+VN4renEdc2d/0bLepWBjVDrddFRQmfQpMaTvR57hEg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=uGNOH5uMbieAYl3IDR8qhGm+vszlc0QiNC8RAOYyEMttzvhABrCvmldfTCpDke3nRbSK4B9nkiWrhXZLydl+sl4eEE4lygMr063c4whTbK6tNqpk6V8o93t3MygE17GszpVuR1GB15+LH6Pt5jsNDEsaknuKHl7yx/ZquOWTXpQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jWn1bSXJ; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jWn1bSXJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 645351F000E9; Fri, 10 Jul 2026 21:23:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783718625; bh=3Vpd1ysaO1UoALGaiGz3UnmHGdjhUtw80tYrdFEd//8=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=jWn1bSXJGBgR/PMhevp19UNRRDpEkdALV+CKLK4NwSjWi9EEw7HmiPUUt8m66gHj8 ed3uIgOOaOM29jJ39Bgr16kpGWy/zyZEBu5FvN8yn8Z8ha1yzM/+pOOtAe43HEpAm2 tbfzYDY0v0fC0LESy8B9pt2KZy3Xh8XsCLuzyslmLMyqclxPxn+jMsm2Eoor4wmUa9 Iu8b/prblcTcFK63wg4qjW3qXSRMmoMojXKd6Z9rJ9Z4xfBZLq7mUP6RnL1ylT7KPx jKHusINy126UId6PJA0puehAeMDCVsUs8Mf/8YM53MVP2Iw5PmnX6aIa7imq1yiOKN Wgjm27KFFMmWw== Date: Fri, 10 Jul 2026 16:23:44 -0500 From: Rob Herring To: Mikhail Lukianchikov Cc: Rengarajan.S@microchip.com, andrew+netdev@lunn.ch, conor+dt@kernel.org, davem@davemloft.net, devicetree@vger.kernel.org, edumazet@google.com, krzk+dt@kernel.org, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, pabeni@redhat.com Subject: Re: [PATCH v2] dt-bindings: net: microchip,lan78xx: convert to DT schema Message-ID: <20260710212344.GA1351459-robh@kernel.org> References: <20260709181724.24682-2-avermoal@gmail.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260709181724.24682-2-avermoal@gmail.com> On Fri, Jul 10, 2026 at 12:17:25AM +0600, Mikhail Lukianchikov wrote: > Convert the Microchip LAN78xx family (LAN7800, LAN7801, LAN7850) binding > documentation from plain text to DT schema. > > The conversion adds proper validation for the 'microchip,led-modes' > property inside the MDIO node and updates the MAINTAINERS entry. > > Signed-off-by: Mikhail Lukianchikov > --- > Changes in v2: > - Rename file to microchip,lan7800.yaml. > - Keeps only one maintainer. > - Code style fixed. > - Example fixed, remove usb-port@1 node. > - Move patternProperties for PHY inside mdio node to fix validation. (suggested by sashiko-bot) > > Link to v1: https://lore.kernel.org/netdev/20260707165840.107409-1-avermoal@gmail.com > > .../bindings/net/microchip,lan7800.yaml | 105 ++++++++++++++++++ > .../bindings/net/microchip,lan78xx.txt | 53 --------- > MAINTAINERS | 3 +- > 3 files changed, 106 insertions(+), 55 deletions(-) > create mode 100644 Documentation/devicetree/bindings/net/microchip,lan7800.yaml > delete mode 100644 Documentation/devicetree/bindings/net/microchip,lan78xx.txt > > diff --git a/Documentation/devicetree/bindings/net/microchip,lan7800.yaml b/Documentation/devicetree/bindings/net/microchip,lan7800.yaml > new file mode 100644 > index 000000000000..289980c23181 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/microchip,lan7800.yaml > @@ -0,0 +1,105 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/microchip,lan7800.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Microchip LAN7800/LAN7801/LAN7850 Gigabit Ethernet controller > + > +maintainers: > + - Rengarajan Sundararajan > + > +description: > + The LAN7800/LAN7801/LAN7850 devices are usually configured by > + programming their OTP or with an external EEPROM, but some > + platforms (e.g. Raspberry Pi 3 B+) have neither. The Device Tree > + properties, if present, override the OTP and EEPROM. > + > +allOf: > + - $ref: /schemas/usb/usb-device.yaml# > + - $ref: /schemas/net/ethernet-controller.yaml# > + > +properties: > + compatible: > + enum: > + - usb424,7800 > + - usb424,7801 > + - usb424,7850 > + > + reg: > + maxItems: 1 > + description: USB port number > + > + local-mac-address: > + $ref: /schemas/types.yaml#/definitions/uint8-array > + minItems: 6 > + maxItems: 6 > + description: > + MAC address to use if not stored in OTP or EEPROM. If present, > + overrides OTP/EEPROM. > + > + mdio: > + $ref: /schemas/net/mdio.yaml# > + unevaluatedProperties: false > + > + patternProperties: > + "^ethernet-phy(@[0-9a-f]+)?$": > + type: object Is there some reason standard phy properties are not valid here? If not, then add: $ref: /schemas/net/ethernet-phy.yaml# unevaluatedProperties: false > + description: | > + PHY node for the embedded or external PHY. The PHY address is > + given by the 'reg' property. Drop. That's true for every MDIO bus. > + > + properties: > + reg: > + maxItems: 1 > + description: PHY address. > + > + microchip,led-modes: > + $ref: /schemas/types.yaml#/definitions/uint32-array > + minItems: 1 > + maxItems: 4 > + description: > + Array of LED mode values for each of up to 4 LEDs. > + Omitted LEDs are turned off. Allowed values are defined > + in include/dt-bindings/net/microchip-lan78xx.h. > + > + required: > + - reg > + > + additionalProperties: false > + > +required: > + - compatible > + - reg > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include > + / { Drop root node. > + usb { > + compatible = "usb-host"; Drop fake compatibles. > + #address-cells = <1>; > + #size-cells = <0>; > + > + ethernet@1 { > + compatible = "usb424,7800"; > + reg = <1>; > + local-mac-address = [00 11 22 33 44 55]; > + > + mdio { > + #address-cells = <1>; > + #size-cells = <0>; > + ethernet-phy@1 { > + reg = <1>; > + microchip,led-modes = < > + LAN78XX_LINK_1000_ACTIVITY > + LAN78XX_LINK_10_100_ACTIVITY > + >; > + }; > + }; > + }; > + }; > + }; > +...