From: Krzysztof Kozlowski <krzk@kernel.org>
To: Charan Pedumuru <charan.pedumuru@gmail.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Thierry Reding <thierry.reding@kernel.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] ASoC: dt-bindings: sound: nvidia,tegra30-ahub: Convert to DT schema
Date: Sat, 11 Jul 2026 17:37:38 +0200 [thread overview]
Message-ID: <20260711-ecstatic-industrious-manticore-f35bb4@quoll> (raw)
In-Reply-To: <20260705-nvidia-ahub-v3-1-bacb7e05bf68@gmail.com>
On Sun, Jul 05, 2026 at 06:32:32AM +0000, Charan Pedumuru wrote:
> + resets:
> + minItems: 11
> + maxItems: 21
> +
> + reset-names:
> + minItems: 11
> + maxItems: 21
> +
> + dmas:
> + minItems: 8
> + maxItems: 20
> +
> + dma-names:
> + minItems: 8
> + items:
> + - const: rx0
> + - const: tx0
> + - const: rx1
> + - const: tx1
> + - const: rx2
> + - const: tx2
> + - const: rx3
> + - const: tx3
> + - const: rx4
> + - const: tx4
> + - const: rx5
> + - const: tx5
> + - const: rx6
> + - const: tx6
> + - const: rx7
> + - const: tx7
> + - const: rx8
> + - const: tx8
> + - const: rx9
> + - const: tx9
> +
> + "#address-cells":
> + enum: [1, 2]
That's a change - old binding was specific and set 1. You need to
explain that in commit msg with reason why.
Value of 2 suggests children need or want 64-bit addressing, which feels
wrong. DTS might not be accurate here.
Best regards,
Krzysztof
prev parent reply other threads:[~2026-07-11 15:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-05 6:32 [PATCH v3] ASoC: dt-bindings: sound: nvidia,tegra30-ahub: Convert to DT schema Charan Pedumuru
2026-07-11 15:37 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260711-ecstatic-industrious-manticore-f35bb4@quoll \
--to=krzk@kernel.org \
--cc=broonie@kernel.org \
--cc=charan.pedumuru@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh@kernel.org \
--cc=thierry.reding@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox