From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE6F2149DF1; Sun, 12 Jul 2026 14:35:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783866922; cv=none; b=l+fcwl1fxMANtqu/ZQ843SNHT5pFdt8p9Q4OEKF/aKpmWlTBDW/d+rO9RNnXxlkC+22lX0USliE30IUG8iC+2UpXnPrQv1Y1Y/W1Vkj5DJ2g+cd9TGCfkp6cwNyhWnXGAOGmjE35dLeyKx6N6MC/8JvREBJK/XIgkeS0zhHgTkg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783866922; c=relaxed/simple; bh=Uf5O0b+6iCsQ99EePPkjf+L/CmQ7N9Ld8f7WkqKW6vc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=RlygRZFe3TmaFSEDlrC3Q1aPfkVY0CdfAwnDHPYKl3ZFPlK+keQyaTY7UYeP5Ff6LrxPjX7fOXL4bWgof4HGBjOdSfb6kqAKnRQoKbQr4OPbPLVq5hSschWnfUNYQxZ0rmVN/jwkS/42AZllax1qXygRC3JH0GwIo6MhDMVVJsM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HsT6GE5s; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HsT6GE5s" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 76F021F000E9; Sun, 12 Jul 2026 14:35:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783866920; bh=7RWLP70+Lk7x6klHiPJCyXJm7RPKA7hKo0HmQbHzxBo=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=HsT6GE5sB5DUFUCMRQkNuUttWd6ae45mL6NHMgYoLcwatlYsmmGzSSeuoN4SwpbrE IT+svOg66VoMcq0agaiYVBUdh4MfFXYOqG05kS1le79jwP59Yp4T9iaTG5i20I3ixs Hnaszlbs0H7ItxEj9ncxu9i5jFuSIos3/5l4v5CEhE9QKMDMsdmHvd6+AkQabYVoni F2sHw1IjVBiS1c2Mb+vSl2dUIp0tOfGAOoxZl9wRxT+a0tQMz+q9AStLX47/3AFeM6 nbh+DJ3IHV9Gjuc0EqmNRToJTUwUNzS5FF7T/QznODpqDSXOU9y+wPKhxceobGSCG2 V9B0EoktaUhwQ== Date: Sun, 12 Jul 2026 16:35:16 +0200 From: Krzysztof Kozlowski To: Junhui Liu Cc: Michael Turquette , Stephen Boyd , Brian Masney , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Philipp Zabel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Richard Cochran , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, netdev@vger.kernel.org, Jerome Brunet Subject: Re: [PATCH v2 1/8] dt-bindings: clk: sun60i-a733-ccu: Add allwinner A733 support Message-ID: <20260712-sexy-polar-cuckoo-cefee4@quoll> References: <20260711-a733-clk-v2-0-974d188cbe0c@pigmoral.tech> <20260711-a733-clk-v2-1-974d188cbe0c@pigmoral.tech> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260711-a733-clk-v2-1-974d188cbe0c@pigmoral.tech> On Sat, Jul 11, 2026 at 04:10:27PM +0800, Junhui Liu wrote: > +properties: > + "#clock-cells": > + const: 1 > + > + "#reset-cells": > + const: 1 > + Please order according to DTS coding style. compatible is ALWAYS the first, then reg. Then name ordering, so reset-cells go to the end. > + compatible: > + enum: > + - allwinner,sun60i-a733-ccu > + - allwinner,sun60i-a733-r-ccu > + > + reg: > + maxItems: 1 > + > + clocks: > + minItems: 4 > + maxItems: 7 > + > + clock-names: > + minItems: 4 > + maxItems: 7 > + > +required: > + - "#clock-cells" > + - "#reset-cells" As well. > + - compatible > + - reg > + - clocks > + - clock-names > + > +allOf: > + - if: > + properties: > + compatible: > + enum: > + - allwinner,sun60i-a733-ccu > + > + then: > + properties: > + clocks: > + items: > + - description: High Frequency Oscillator (19.2MHz, 24MHz, or 26MHz) > + - description: Low Frequency Oscillator (usually at 32kHz) > + - description: Internal Oscillator > + - description: Low Frequency Oscillator fanout > + > + clock-names: > + items: > + - const: hosc > + - const: losc > + - const: iosc > + - const: losc-fanout > + > + - if: > + properties: > + compatible: > + enum: > + - allwinner,sun60i-a733-r-ccu > + > + then: > + properties: > + clocks: > + items: > + - description: High Frequency Oscillator (19.2MHz, 24MHz, or 26MHz) > + - description: Low Frequency Oscillator (usually at 32kHz) > + - description: Internal Oscillator > + - description: System 24MHz Clock > + - description: Peripherals PLL 0 (200 MHz output) > + - description: Peripherals PLL 0 (300 MHz output) > + - description: Peripherals PLL 1 (300 MHz output) > + > + clock-names: > + items: > + - const: hosc > + - const: losc > + - const: iosc > + - const: sys-24m > + - const: pll-periph0-200m > + - const: pll-periph0-300m > + - const: pll-periph1-300m > + > +additionalProperties: false > + > +examples: > + - | > + clock-controller@2002000 { > + compatible = "allwinner,sun60i-a733-ccu"; > + reg = <0x02002000 0x2000>; > + clocks = <&osc>, <&rtc 0>, <&rtc 2>, <&rtc 1>; > + clock-names = "hosc", "losc", "iosc", "losc-fanout"; > + #clock-cells = <1>; > + #reset-cells = <1>; > + }; > + > +... > diff --git a/include/dt-bindings/clock/sun60i-a733-ccu.h b/include/dt-bindings/clock/sun60i-a733-ccu.h > new file mode 100644 > index 000000000000..6742070e3086 > --- /dev/null > +++ b/include/dt-bindings/clock/sun60i-a733-ccu.h Filename must match compatible. > @@ -0,0 +1,290 @@ > +/* SPDX-License-Identifier: (GPL-2.0-only OR MIT) */ Why different license than the binding? > +/* > + * Copyright (C) 2026 Junhui Liu ... > +#define CLK_BUS_DSC 257 > +#define CLK_CSI_MASTER0 258 > +#define CLK_CSI_MASTER1 259 > +#define CLK_CSI_MASTER2 260 > +#define CLK_CSI 261 > +#define CLK_BUS_CSI 262 > +#define CLK_ISP 263 > +#define CLK_RES_DCAP_24M 264 > +#define CLK_APB2JTAG 265 > +#define CLK_FANOUT_24M 266 > +#define CLK_FANOUT_12M 267 > +#define CLK_FANOUT_16M 268 > +#define CLK_FANOUT_25M 269 > +#define CLK_FANOUT_27M 270 > +#define CLK_FANOUT_PCLK 271 > +#define CLK_FANOUT0 272 > +#define CLK_FANOUT1 273 > +#define CLK_FANOUT2 274 > +#define CLK_FANOUT3 275 > + > +#endif /* _DT_BINDINGS_CLK_SUN60I_A733_CCU_H_ */ > diff --git a/include/dt-bindings/clock/sun60i-a733-r-ccu.h b/include/dt-bindings/clock/sun60i-a733-r-ccu.h > new file mode 100644 > index 000000000000..1d3845b483bf > --- /dev/null > +++ b/include/dt-bindings/clock/sun60i-a733-r-ccu.h Here as well and so on (other places as well). Best regards, Krzysztof