From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9AFB82F39B5 for ; Sun, 12 Jul 2026 09:53:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783849987; cv=none; b=GZOdOwXYCDI06jWm6AMMEsD5gjE61+u1l5vRJSIaEbRT44LLS2fH+FY1bspHeS5S5pXxwuz8y4YMwLV/lTdpC1FtBsifvwU+C1s/D2apwzf0NbpabSREFLbXk6LLqkP9j/fgNgT2QjEkAsQBGhRuvrrJTO6uKjjFS2Fs3nUUKcg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783849987; c=relaxed/simple; bh=oYwcdM+FW7H4Ym9GEN20MESRtKTVs/HAvOI0waX8Ktg=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=TRVKC4lYpP2ntDUezhzuT1kvfB838HcdxQ2L/dzJjLo4hgEOS/seWcriEBLDxRbybMegjjKr6rEyrEQ3vR2e6RyzfIeU2kKLqEGyDqXV5lC0H4PzrUtc0BXSnG2EE4z7kf3e9gPTW8lGhCXBN3fnxxzBMcQcQgNRn5A1ENe9ZMQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=e2OnnNkb; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="e2OnnNkb" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 011D21F000E9; Sun, 12 Jul 2026 09:53:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783849986; bh=M4pmzuZiQ2iGlTf1I5rCLAUvTv4hVD9Fig0TepluapI=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=e2OnnNkbkEV5n0g9jAPj0HmTP1azHWgvOcRpkigrP+oZY6a3tp4Lr9KHVY1bj7Aiz V9OomAJ76fvXIZyH1NvZpaVFj5h6E56B9kueIrJNIqEQvcrpFuuVlAlcxvhzsj4KO2 Ja7+L9PWPfFdTOw2iVqWJKO6g4qeCuh6n0K4d/ZV2DIyCL5u6H5HdsJAnNC2GHwuvy 2S0HFJ03b4+WDqwu4ZTZFQWHeAmY8BSOUGja06o3PiUkohe2TRWNE6Oqsf3J6m8SCU 1CD52ReeVLYrrLx40aKq8E7s+5DFWTVRvqD2pdomRMSwkHvS8wM3ePjxPP2nxcPFZx ccqQsC5+pOSFg== From: sashiko-bot@kernel.org Subject: Re: [PATCH 01/12] arm64: dts: apple: t8112: Add SMC hwmon node Reply-To: sashiko-reviews@lists.linux.dev To: "James Calligeros" Cc: conor+dt@kernel.org, robh@kernel.org, devicetree@vger.kernel.org In-Reply-To: <20260712-smc-subdev-dt-v1-1-7763006d57c7@gmail.com> References: <20260712-smc-subdev-dt-v1-0-7763006d57c7@gmail.com> <20260712-smc-subdev-dt-v1-1-7763006d57c7@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Sun, 12 Jul 2026 09:53:05 +0000 Message-Id: <20260712095306.011D21F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Medium] Adding an unconditionally enabled `smc_hwmon` node without child= sensors triggers a spurious `dev_err` on boot on all T8112 platforms. -- --- Patch [1]: [PATCH 01/12] arm64: dts: apple: t8112: Add SMC hwmon node -= -- commit 98dce99825d4d377b6a5ac4bb63591402516eb04 Author: James Calligeros arm64: dts: apple: t8112: Add SMC hwmon node This commit adds the SMC hwmon subdevice node to the Apple T8112 device tre= e. > diff --git a/arch/arm64/boot/dts/apple/t8112.dtsi b/arch/arm64/boot/dts/a= pple/t8112.dtsi > index 85c47422d4e8e..a3241c816c26b 100644 > --- a/arch/arm64/boot/dts/apple/t8112.dtsi > +++ b/arch/arm64/boot/dts/apple/t8112.dtsi > @@ -921,6 +921,10 @@ smc_reboot: reboot { > "boot_error_count", "panic_count"; > }; > =20 > + smc_hwmon: hwmon { > + compatible =3D "apple,smc-hwmon"; > + }; > + [Severity: Medium] Will this unconditionally enabled node trigger a spurious error on boot? Because this node is added without any child sensors and lacks a status =3D "disabled" property, the SMC MFD core will instantiate the macsmc-hwmon platform device. When the probe function runs, it won't find any sensors, and will print an error message to the kernel log before returning -ENODEV: drivers/hwmon/macsmc-hwmon.c:macsmc_hwmon_probe() { ... if (!hwmon->curr.count && !hwmon->fan.count && !hwmon->power.count && !hwmon->temp.count && !hwmon->volt.count) { dev_err(hwmon->dev, "No valid sensors found of any supported type\n"); return -ENODEV; } ... } Should this node be added with status =3D "disabled" to prevent the macsmc-hwmon driver from probing and polluting dmesg on platforms without sensors? > rtc { > compatible =3D "apple,smc-rtc"; > nvmem-cells =3D <&rtc_offset>; --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260712-smc-subdev= -dt-v1-0-7763006d57c7@gmail.com?part=3D1