Re: [PATCH v7 2/4] dt-bindings: hwmon: Add Sensirion SHT30 series

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Device tree nodes using the newly defined compatible strings will silently fail to probe because the existing `sht3x` driver lacks a corresponding `of_match_table`.
--

--- Patch [2]: [PATCH v7 2/4] dt-bindings: hwmon: Add Sensirion SHT30 series ---
commit a41d5511b126bf5d822219f86d5fe60736eb2e81
Author: Zaixiang Xu <zaixiang.xu.dev@gmail.com>

dt-bindings: hwmon: Add Sensirion SHT30 series

Add a YAML devicetree binding for the Sensirion SHT3x/STS3x sensor
family and the compatible GXCAS GXHT30, with the ALERT interrupt,
nRESET GPIO and VDD supply as optional properties.

> diff --git a/Documentation/devicetree/bindings/hwmon/sensirion,sht30.yaml b/Documentation/devicetree/bindings/hwmon/sensirion,sht30.yaml
> new file mode 100644
> index 0000000000000..dee0252941c29
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/sensirion,sht30.yaml
[ ... ]
> +maintainers:
> +  - Zaixiang Xu <zaixiang.xu.dev@gmail.com>
> +
> +properties:
> +  compatible:
> +    oneOf:
> +      - enum:
> +          - sensirion,sht30
> +          - sensirion,sts30

[Severity: Medium]
Will devices using these newly defined compatible strings silently fail to probe?

Looking at the existing driver in drivers/hwmon/sht3x.c, it lacks an
of_match_table and relies on this legacy ID table:

static const struct i2c_device_id sht3x_ids[] = {
        { .name = "sht3x", .driver_data = sht3x },
        { .name = "sts3x", .driver_data = sts3x },
        { .name = "sht85", .driver_data = sht3x },
        { }
};

Because it relies on the I2C core extracting the compatible string to use as the
legacy matching name, it will fail to match against strings like "sht30",
"sts30", or "gxht30" from this new binding.

Does the driver need to be updated with an of_match_table to prevent this
regression?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260713074559.12196-1-zaixiang.xu.dev@gmail.com?part=2