Re: [PATCH 1/3] arm64: dts: qcom: hamoa-iot-evk: Describe the PCIe M.2 Key E connector

[Wei Deng <wei.deng@oss.qualcomm.com>]

On Fri, 10 Jul 2026, Konrad Dybcio wrote:
> On 7/9/26 9:29 AM, Wei Deng wrote:
> > The hamoa IoT EVK has the PCIe M.2 Mechanical Key E connector to
> > connect wireless connectivity cards over PCIe and UART interfaces.
> > Hence, describe the connector node, link it with the PCIe 4 Root Port
> > node and replace the static BT serdev under UART14 and the
> > chip-specific wifi@0 child node with graph port/endpoints, allowing
> > the pwrseq-pcie-m2 driver to power the card and dynamically create
> > the BT serdev device.
> > 
> > The M.2 Key E connector is powered by vreg_wcn_3p3. WLAN enable is
> > controlled via W_DISABLE1# (GPIO117) and BT enable via W_DISABLE2#
> > (GPIO116), both described as active-low GPIOs on the connector node.
> > 
> > Remove the chip-specific wcn7850-pmu node as the M.2 connector
> > approach replaces the WCN7850-specific power sequencing with a
> > chip-agnostic one managed by the pwrseq-pcie-m2 driver.
> > 
> > Also add 'compatible = "pciclass,0604"' to pcie4_port0 in hamoa.dtsi
> > to allow the PCI subsystem to associate the DT node with the
> > PCI-to-PCI bridge device.
> > 
> > Signed-off-by: Wei Deng <wei.deng@oss.qualcomm.com>
> > ---
> 
> [...]
> 
> > @@ -1025,19 +1004,10 @@ &pcie4_port0 {
> >  	reset-gpios = <&tlmm 146 GPIO_ACTIVE_LOW>;
> >  	wake-gpios = <&tlmm 148 GPIO_ACTIVE_LOW>;
> >  
> > -	wifi@0 {
> > -		compatible = "pci17cb,1107";
> > -		reg = <0x10000 0x0 0x0 0x0 0x0>;
> > -
> > -		vddaon-supply = <&vreg_pmu_aon_0p59>;
> > -		vddwlcx-supply = <&vreg_pmu_wlcx_0p8>;
> > -		vddwlmx-supply = <&vreg_pmu_wlmx_0p85>;
> > -		vddrfacmn-supply = <&vreg_pmu_rfa_cmn>;
> > -		vddrfa0p8-supply = <&vreg_pmu_rfa_0p8>;
> > -		vddrfa1p2-supply = <&vreg_pmu_rfa_1p2>;
> > -		vddrfa1p8-supply = <&vreg_pmu_rfa_1p8>;
> > -		vddpcie0p9-supply = <&vreg_pmu_pcie_0p9>;
> > -		vddpcie1p8-supply = <&vreg_pmu_pcie_1p8>;
> > +	port {
> > +		pcie4port0_ep: endpoint {
> 
> "pcie4_port0_ep", please
> 
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 
> Konrad
> 

Thanks for the review!

Will fix in v2.

-- 
Best Regards,
Wei Deng