Re: [PATCH v3 1/3] dt-bindings: mfd: mediatek: mt6397: add mt6323 PMIC EFUSE

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The `efuse` node schema sets `unevaluatedProperties: false` but omits the reference to the standard NVMEM subsystem schema (`/schemas/nvmem/nvmem.yaml#`), rejecting valid generic NVMEM properties.
- [Low] The commit message description begins with a lowercase letter, violating MFD subsystem guidelines.
--

--- Patch [1]: [PATCH v3 1/3] dt-bindings: mfd: mediatek: mt6397: add mt6323 PMIC EFUSE ---
commit 26cbf9fd727c6628394df9e87fedf646b54dc080
Author: Roman Vivchar <rva333@protonmail.com>

dt-bindings: mfd: mediatek: mt6397: add mt6323 PMIC EFUSE

The MediaTek mt6323 PMIC includes an EFUSE used for storing calibration
data.

> dt-bindings: mfd: mediatek: mt6397: add mt6323 PMIC EFUSE

[Severity: Low]
This isn't a bug, but the commit description starts with a lowercase letter.
Should the description after the subsystem prefix be capitalized according to
MFD subsystem conventions?

> diff --git a/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml b/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml
> --- a/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml
> +++ b/Documentation/devicetree/bindings/mfd/mediatek,mt6397.yaml
> @@ -159,6 +159,23 @@ properties:

[ ... ]

> +  efuse:
> +    type: object
> +    unevaluatedProperties: false
> +    description:
> +      The efuse is responsible for storing calibration data, such as thermal
> +      sensor calibration.
> +
> +    properties:
> +      compatible:
> +        const: mediatek,mt6323-efuse
> +
> +      nvmem-layout:
> +        $ref: /schemas/nvmem/layouts/nvmem-layout.yaml#

[Severity: Medium]
Since this node uses unevaluatedProperties: false, does it also need a
reference to the standard NVMEM schema ($ref: /schemas/nvmem/nvmem.yaml#)?

Without it, wouldn't standard NVMEM properties like read-only or wp-gpios
cause schema validation failures if they are added?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260713-mt6323-nvmem-v3-0-205c39267a24@protonmail.com?part=1