From: sashiko-bot@kernel.org
To: "Mikhail Lukianchikov" <avermoal@gmail.com>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v4] dt-bindings: net: microchip,lan78xx: convert to DT schema
Date: Mon, 13 Jul 2026 11:39:04 +0000 [thread overview]
Message-ID: <20260713113904.D8FAE1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260712113821.12543-1-avermoal@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Commit message includes inaccurate claims regarding changes to the MAINTAINERS file.
--
--- Patch [1]: [PATCH v4] dt-bindings: net: microchip,lan78xx: convert to DT schema ---
commit f1714d97cf714d559260a426c4169db231384ff6
Author: Mikhail Lukianchikov <avermoal@gmail.com>
dt-bindings: net: microchip,lan78xx: convert to DT schema
This commit converts the Microchip LAN78xx family binding documentation
from plain text to DT schema. It also updates the MAINTAINERS file to
point to the new yaml file.
Link: https://lore.kernel.org/netdev/20260711105537.11065-2-avermoal@gmail.com
> Restoring a mistakenly deleted email in MAINTAINERS file and fixing
> microchip,lan7800.yaml.
[Severity: Medium]
Is this commit message description accurate for the changes included in
this patch?
Looking at the diff for the MAINTAINERS file, the patch only updates the
file path from .txt to .yaml:
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f37a81950e250..5de154167b332 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -27931,7 +27931,7 @@ M: Rengarajan Sundararajan <Rengarajan.S@microchip.com>
> M: UNGLinuxDriver@microchip.com
> L: netdev@vger.kernel.org
> S: Maintained
> -F: Documentation/devicetree/bindings/net/microchip,lan78xx.txt
> +F: Documentation/devicetree/bindings/net/microchip,lan7800.yaml
It does not appear to restore or add any email addresses. Could this text
in the commit description be an accidental inclusion of a changelog note
meant for below the '---' line?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260712113821.12543-1-avermoal@gmail.com?part=1
prev parent reply other threads:[~2026-07-13 11:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-12 11:38 [PATCH v4] dt-bindings: net: microchip,lan78xx: convert to DT schema Mikhail Lukianchikov
2026-07-13 6:21 ` Krzysztof Kozlowski
2026-07-13 11:39 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260713113904.D8FAE1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=avermoal@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox