Re: [PATCH v2 13/18] arm64: dts: ti: k3-j784s4-evm: Add overlay for J7EXPA01EVM Fusion2

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit message claims to have fixed DTS styling and whitespace inconsistencies in port definitions, but these fixes were not applied to the third deserializer ('deser@32').
--

--- Patch [13]: [PATCH v2 13/18] arm64: dts: ti: k3-j784s4-evm: Add overlay for J7EXPA01EVM Fusion2 ---
commit c8270b1db48b4db03ed35600960afc0c87b8b5ff
Author: Vaishnav Achath <vaishnav.a@ti.com>

arm64: dts: ti: k3-j784s4-evm: Add overlay for J7EXPA01EVM Fusion2

This commit adds a device tree overlay to support the J7EXPA01EVM Fusion2
serial capture expansion board on the J784S4-EVM. The board features three
UB9702 deserializers aggregating data over the FPDLink-IV interface.

> diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-evm-fpdlink-iv-fusion.dtso b/arch/arm64/boot/dts/ti/k3-j784s4-evm-fpdlink-iv-fusion.dtso
> new file mode 100644
> index 0000000000000..0f95d19ebd175
> --- /dev/null
> +++ b/arch/arm64/boot/dts/ti/k3-j784s4-evm-fpdlink-iv-fusion.dtso

[ ... ]

> +	deser@32 {
> +		compatible = "ti,ds90ub9702-q1";
> +		reg = <0x32>;
> +		clocks = <&clk_fusion_25M_fixed>;
> +		clock-names = "refclk";
> +		i2c-alias-pool = <0x6a 0x6b 0x6c 0x6d 0x6e 0x6f>;
> +
> +		deserializer_2_ports: ports {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +
> +			port@0{
> +				reg= <0>;
> +				status = "disabled";
> +			};

[Severity: Low]
This isn't a bug, but the v2 changelog mentions fixing DTS styling and
whitespace inconsistencies in the port definitions. Did these fixes get
missed for the third deserializer (deser@32)?

The first two deserializers correctly use "port@0 {" and "reg = <0>;", while
these nodes still have missing spaces around the curly braces and equals sign.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260713113423.2310443-1-y-abhilashchandra@ti.com?part=13