From: sashiko-bot@kernel.org
To: "Rakesh Kota" <rakesh.kota@oss.qualcomm.com>
Cc: conor+dt@kernel.org, robh@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v5 1/2] dt-bindings: power: reset: qcom-pon: Add new compatible PMM8654AU
Date: Mon, 13 Jul 2026 12:13:27 +0000 [thread overview]
Message-ID: <20260713121328.339151F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260713-b4-add_pwrkey_and_resin-v5-1-3bea476e1453@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
Pre-existing issues:
- [High] The schema incorrectly forbids `mode-*` properties for `pmk8350-pon` and its fallbacks, breaking reboot mode configuration.
--
--- Patch [1]: [PATCH v5 1/2] dt-bindings: power: reset: qcom-pon: Add new compatible PMM8654AU ---
commit c59d0da4493e27ba6b287b072dffcd65652a9310
Author: Rakesh Kota <rakesh.kota@oss.qualcomm.com>
dt-bindings: power: reset: qcom-pon: Add new compatible PMM8654AU
This commit introduces the PMM8654AU compatible string as a fallback to the
baseline PMK8350 PON implementation. It also updates the schema to enforce
that both the hlos and pbs register address spaces are always present for
the Gen3 PON peripherals.
> diff --git a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml
> index 979a377cb4ffd..09eea48c709e5 100644
> --- a/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml
> +++ b/Documentation/devicetree/bindings/power/reset/qcom,pon.yaml
> @@ -17,12 +17,16 @@ description: |
>
> properties:
> compatible:
> - enum:
> - - qcom,pm8916-pon
> - - qcom,pm8941-pon
> - - qcom,pms405-pon
> - - qcom,pm8998-pon
> - - qcom,pmk8350-pon
> + oneOf:
> + - enum:
> + - qcom,pm8916-pon
> + - qcom,pm8941-pon
> + - qcom,pms405-pon
> + - qcom,pm8998-pon
> + - qcom,pmk8350-pon
> + - items:
> + - const: qcom,pmm8654au-pon
> + - const: qcom,pmk8350-pon
[Severity: High]
This is a pre-existing issue, but does the current schema incorrectly forbid
mode-* properties for pmk8350-pon and its fallbacks, breaking reboot mode
configuration?
Because the Gen3 compatibles are missing from the earlier allOf if condition
that matches pm8916-pon, pms405-pon, and pm8998-pon, they fall into the else
branch:
else:
patternProperties:
"^mode-.*$": false
Will this cause dtbs_check to spuriously reject valid mode-* properties for
the newly added pmm8654au-pon PMIC?
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260713-b4-add_pwrkey_and_resin-v5-0-3bea476e1453@oss.qualcomm.com?part=1
next prev parent reply other threads:[~2026-07-13 12:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-13 11:58 [PATCH v5 0/2] monaco: Add PMM8654AU PON support Rakesh Kota
2026-07-13 11:58 ` [PATCH v5 1/2] dt-bindings: power: reset: qcom-pon: Add new compatible PMM8654AU Rakesh Kota
2026-07-13 12:13 ` sashiko-bot [this message]
2026-07-13 11:58 ` [PATCH v5 2/2] arm64: dts: qcom: monaco-pmics: Add PON power key and reset inputs Rakesh Kota
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260713121328.339151F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=rakesh.kota@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox