From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69186345CC0; Mon, 13 Jul 2026 17:54:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783965243; cv=none; b=cqKWspL1aCtimJrOACjtJqfBEIvNSXxiMlo4EBvswXf6OFVsp8gkOOvvkr0xud9cbp//K88lHikwuj9GybDPAbZIoJEYwqDWXWNYziOJ84CKUjdzd1y4EAXKftxQC/QgX1/pUq37/Qhwta7y21atQ5Gn4LtJd3t8tTJudUjaK4s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783965243; c=relaxed/simple; bh=xpgHPT/JcnkDhaTFjmE+nZeO4XbztrxHgTdL/5lej04=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=bvFKrK/iUnOoZfuo38UDYN8bppZsJV1470aZO5mhtoat7QAh7USzrfCwIsq8/ZjPxcnfzdF2nyHJMidyjUJtehios45Y1LWjwqlwQQVkBKOyTnSqjduomgAlOSdlNGrkAwSicbtN5pAXkAYk+9XQzWEBlpvD3Qw9QDg8FFzO6oA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QIFnMeAW; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QIFnMeAW" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E10EB1F000E9; Mon, 13 Jul 2026 17:54:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783965242; bh=5hmDkoykXyuPCNX5o4VG9nAOn2vOS+ZzIkyEv+1eQgQ=; h=Date:From:To:Cc:Subject:In-Reply-To; b=QIFnMeAWfUu5xUX6zoFQeRz6/U1yN51/WVkbP9f8XVzRUvQVcT1PnbYX012sRdGsu Yyal/hZB1vTsCmmRZ1bfV9/nK3hfKtCLBdKy6S/lOLRz1Oi6xaTlUo0xAJH3y5yvxM LF+DBgK79KTe3L40BkSYfaO9GEaxv0EosnBX1cz3wVSzqIt6k4wZKpttVTk6Blf79y l5DQy8Qg/eQRV85kTfyR1ZXpHugtN7H2fv/jsSbItz9sx+XylYKfvyjHwM9kZFH0Ov dqRv/ToS+zowvCFe6dUK0hqlP3fS9gS7EEOwmUmNOJYpLQmrIqhxrlv50iR7bml+nK mIwHXEWzlrz2w== Date: Mon, 13 Jul 2026 12:54:00 -0500 From: Bjorn Helgaas To: Marek Vasut Cc: Marc Zyngier , linux-pci@vger.kernel.org, kernel test robot , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , Catalin Marinas , Conor Dooley , Geert Uytterhoeven , Krzysztof Kozlowski , Lorenzo Pieralisi , Manivannan Sadhasivam , Rob Herring , Yoshihiro Shimoda , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH] PCI: rcar-gen4: Inline GIC_TRANSLATER offset macro Message-ID: <20260713175400.GA1258926@bhelgaas> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2cb03029-0957-4ed8-98bd-9b3e0e0bce2d@mailbox.org> On Fri, Jul 10, 2026 at 03:35:10PM +0200, Marek Vasut wrote: > On 7/10/26 10:30 AM, Marc Zyngier wrote: > > On Thu, 09 Jul 2026 21:10:03 +0100, > > Marek Vasut wrote: > > > > > > Instead of pulling in the whole linux/irqchip/arm-gic-v3.h , > > > copy the one GITS_TRANSLATER register offset macro directly into > > > the driver. This repairs the ability to build the driver on > > > non-ARM non-GIC targets the way it was possible until now, which > > > retains good build test coverage. > ... > So in the end, it is either this patch or limit the build to > arm/arm64 . At least this patch still allows building this driver > with more compilers on the various build bots, so I would opt for > this patch here. I like the build coverage, but duplicating the #define doesn't really seem good to me. It makes readability worse because cscope/tags now sees two definitions without an obvious reason.