From: sashiko-bot@kernel.org
To: "Komal Bajaj" <komal.bajaj@oss.qualcomm.com>
Cc: dmaengine@vger.kernel.org, conor+dt@kernel.org, robh@kernel.org,
devicetree@vger.kernel.org, vkoul@kernel.org,
Frank.Li@kernel.org
Subject: Re: [PATCH v6 07/11] arm64: dts: qcom: shikra: Enable CDSP, LPAICP and MPSS on EVK boards
Date: Mon, 13 Jul 2026 19:42:46 +0000 [thread overview]
Message-ID: <20260713194246.A67CA1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260714-shikra-dt-m1-v6-7-bee265d3499b@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The MPSS firmware path for the IQS EVK board incorrectly uses the CQS board's firmware directory due to a likely copy-paste error.
--
--- Patch [7]: [PATCH v6 07/11] arm64: dts: qcom: shikra: Enable CDSP, LPAICP and MPSS on EVK boards ---
commit c0f88c4032c0357d309d8548cec707d24e9ad614
Author: Bibek Kumar Patro <bibek.patro@oss.qualcomm.com>
arm64: dts: qcom: shikra: Enable CDSP, LPAICP and MPSS on EVK boards
This commit enables the CDSP, LPAICP, and MPSS remote processors for the
Qualcomm Shikra CQM, CQS, and IQS EVK boards.
[ ... ]
> diff --git a/arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts b/arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts
> index 3003a47bd7594..727809430fd15 100644
> --- a/arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts
> +++ b/arch/arm64/boot/dts/qcom/shikra-iqs-evk.dts
[ ... ]
> +&remoteproc_mpss {
> + firmware-name = "qcom/shikra/cqs/qdsp6sw.mbn";
[Severity: Medium]
Does this firmware path incorrectly point to the cqs directory instead of iqs
for the IQS EVK board? It looks like this might cause the modem remoteproc on
the IQS board to load the wrong firmware intended for the CQS board.
> +
> + status = "okay";
> +};
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260714-shikra-dt-m1-v6-0-bee265d3499b@oss.qualcomm.com?part=7
next prev parent reply other threads:[~2026-07-13 19:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-13 19:36 [PATCH v6 00/11] arm64: dts: qcom: Extend Shikra device tree with peripheral and subsystem support Komal Bajaj
2026-07-13 19:36 ` [PATCH v6 01/11] dt-bindings: interconnect: qcom-bwmon: Add Shikra cpu-bwmon compatible Komal Bajaj
2026-07-13 19:36 ` [PATCH v6 02/11] arm64: dts: qcom: Add QUPv3 configuration for Shikra Komal Bajaj
2026-07-13 19:51 ` sashiko-bot
2026-07-13 19:36 ` [PATCH v6 03/11] arm64: dts: qcom: shikra: Add DDR BWMON support Komal Bajaj
2026-07-13 19:36 ` [PATCH v6 04/11] arm64: dts: qcom: shikra: Add cpufreq-hw, EPSS L3 interconnect and OPP tables Komal Bajaj
2026-07-13 19:36 ` [PATCH v6 05/11] arm64: dts: qcom: shikra: Add SMP2P nodes Komal Bajaj
2026-07-13 19:36 ` [PATCH v6 06/11] arm64: dts: qcom: shikra: Add CDSP, LPAICP, MPSS remoteproc PAS nodes Komal Bajaj
2026-07-13 19:36 ` [PATCH v6 07/11] arm64: dts: qcom: shikra: Enable CDSP, LPAICP and MPSS on EVK boards Komal Bajaj
2026-07-13 19:42 ` sashiko-bot [this message]
2026-07-13 19:36 ` [PATCH v6 08/11] arm64: dts: qcom: shikra: Enable TSENS and thermal zones Komal Bajaj
2026-07-13 19:36 ` [PATCH v6 09/11] arm64: dts: qcom: shikra: add WiFi node support Komal Bajaj
2026-07-13 19:36 ` [PATCH v6 10/11] arm64: dts: qcom: shikra: Enable WiFi/BT on SoMs Komal Bajaj
2026-07-13 19:57 ` sashiko-bot
2026-07-13 19:37 ` [PATCH v6 11/11] arm64: dts: qcom: shikra: Add gpio-reserved-ranges to tlmm Komal Bajaj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260713194246.A67CA1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=komal.bajaj@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox