From: sashiko-bot@kernel.org
To: "Joachim Eastwood" <joachim.eastwood@gmail.com>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 08/12] arm64: dts: rockchip: rk3588s-nanopi-r6: add gmac1 add phy-supply
Date: Mon, 13 Jul 2026 20:36:28 +0000 [thread overview]
Message-ID: <20260713203629.517DC1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260713-nanopi-m6-v3-8-227567ffc5dc@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Typo in the commit message: 'is power from' instead of 'is powered from'.
--
--- Patch [8]: [PATCH v3 08/12] arm64: dts: rockchip: rk3588s-nanopi-r6: add gmac1 add phy-supply ---
commit ab3003db2e086a8af07b8d7a91353a3b0f880f80
Author: Joachim Eastwood <joachim.eastwood@gmail.com>
arm64: dts: rockchip: rk3588s-nanopi-r6: add gmac1 add phy-supply
This commit adds the phy-supply property to the gmac1 node for the
rk3588s-nanopi-r6 device tree, linking it to the VCC_3V3_S3 power rail.
> The RTL8211F Ethernet phy is power from the VCC_3V3_S3 rail.
[Severity: Low]
This isn't a bug, but there is a typo here. It should say "is powered from"
instead of "is power from".
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260713-nanopi-m6-v3-0-227567ffc5dc@gmail.com?part=8
next prev parent reply other threads:[~2026-07-13 20:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-13 20:30 [PATCH v3 00/12] arm64: dts: rockchip: Add NanoPi M6 board Joachim Eastwood via B4 Relay
2026-07-13 20:30 ` [PATCH v3 01/12] dt-bindings: arm: rockchip: add FriendlyElec NanoPi M6 Joachim Eastwood via B4 Relay
2026-07-13 20:30 ` [PATCH v3 02/12] arm64: dts: rockchip: rk3588s-nanopi-r6: fix missing sdmmc cd pinctrl Joachim Eastwood via B4 Relay
2026-07-13 20:30 ` [PATCH v3 03/12] arm64: dts: rockchip: rk3588s-nanopi-r6: fix missing pcie rst pinctrl Joachim Eastwood via B4 Relay
2026-07-14 13:02 ` Diederik de Haas
2026-07-13 20:30 ` [PATCH v3 04/12] arm64: dts: rockchip: rk3588s-nanopi-r6: remove pull up on rtc int pin Joachim Eastwood via B4 Relay
2026-07-13 20:30 ` [PATCH v3 05/12] arm64: dts: rockchip: rk3588s-nanopi-r6: pcie2x1l2: add clkreq Joachim Eastwood via B4 Relay
2026-07-13 20:30 ` [PATCH v3 06/12] arm64: dts: rockchip: rk3588s-nanopi-r6: remove always-on and boot-on from vdd_npu_s0 reg Joachim Eastwood via B4 Relay
2026-07-13 20:30 ` [PATCH v3 07/12] arm64: dts: rockchip: rk3588s-nanopi-r6: remove useless vcc_3v3_pcie20 Joachim Eastwood via B4 Relay
2026-07-13 20:30 ` [PATCH v3 08/12] arm64: dts: rockchip: rk3588s-nanopi-r6: add gmac1 add phy-supply Joachim Eastwood via B4 Relay
2026-07-13 20:36 ` sashiko-bot [this message]
2026-07-13 20:30 ` [PATCH v3 09/12] arm64: dts: rockchip: rk3588s-nanopi-r6: remove bogus vcc5v0_usb regulator Joachim Eastwood via B4 Relay
2026-07-13 20:30 ` [PATCH v3 10/12] arm64: dts: rockchip: rk3588s-nanopi-r6: add comment to gmac phy-mode Joachim Eastwood via B4 Relay
2026-07-13 20:30 ` [PATCH v3 11/12] arm64: dts: rockchip: rk3588s-nanopi-r6: refactor to support M6 boards Joachim Eastwood via B4 Relay
2026-07-13 20:41 ` sashiko-bot
2026-07-13 20:30 ` [PATCH v3 12/12] arm64: dts: rockchip: add support for NanoPi M6 board Joachim Eastwood via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260713203629.517DC1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joachim.eastwood@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox