From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD2F538D3E2 for ; Tue, 14 Jul 2026 11:59:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784030344; cv=none; b=ffPCfWFaruocxiRVpvDBKeKznXvGldPdEWcDEK2DJ3+bI8MhGsZU2qBOKEEA7pBV+AxafN/11xsOFO/d9mUG8WCO3xMp10UDSN7pJ+MTRswx+jchbuZfiQxOQNKzhZJIVldWhD3hJ8x9gYhZCk1D1cYbjwmCuNenICU5ffjls2Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784030344; c=relaxed/simple; bh=eCjKiSsxMp3e7aAVuQZl2wQDtfBKEbKNnbzvbF592Vo=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IjnC1QCfI/DWLtveVg4xd+v3TEtsLu4hv7hRb5sUelGW0ajwJL7JsfdmTEri9q7yI1V1i3hUFcik2B1Mw8Jg0QlF8tkeQIHxV8RIsiQM9gLX0MVljRCzJZ4SoGtMQIBQfm4gK1i9xph+QkKxuYInMRc5xG5uBtHSAjbxEN9qwm8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mvjI1uJv; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mvjI1uJv" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-493b1710405so22433045e9.2 for ; Tue, 14 Jul 2026 04:59:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784030340; x=1784635140; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=Oqp269fPqkkP0y4F1qhxEIUZdEYzw+E7N13spqrG24g=; b=mvjI1uJvlDqzyAB6vONyr0hgVo5xPCln18h7LbF26cqg1tRMP5eLg4o+gQcp2vLaR4 1XqLmMidej9aJqE+j2MSh1CCy/k0hcskkLyFYldVVq+YuK8xsk58pbyDUOchcpyU5Uuj KHhHawYEUaW4u7Wz6QsD9muGxAsOtf+ebu/9hzMHpHEgXfyjjxHXcGDKFtVgye0PKz+4 5nfvyCgzMJC9d9DNtwG9uoql/kcYFVm7ZwnjD6V8oEItw3P2yxLhN0dLEFQG0fXRquP5 uaiYsLMGsVqq5Fb6kdt8MsFAN++PDKMmcbcZZnTnuaso5re1y3Jti1tRR96s/hf/1sn1 RFPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784030340; x=1784635140; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=Oqp269fPqkkP0y4F1qhxEIUZdEYzw+E7N13spqrG24g=; b=Ywkehdh2MdRELpQnMnamn4i4CPlbNt8758AFgw7rT1qxiVn30nmzM4Ive0UmmLS4pP DJJUcBhs17isAWwQ3BkCqmwwaQVApzLRZqigpJX6VX1xlVtSsJtTXRizk6KpxUciMU2L UH/Zk+Ditz37MGe9DyuJvz8Ek4rjVJ9xR24FDfyDuwgt6SQUXy0mWB99RFFCb1RhDNSY U4SsQL/WviHwenJIw09FMwXkdi6rtC5eymnzmFKV0q676o7S6hyV5C8pZnd/qrfLbCPY 7QxZH4c5U/lhmCGQlQO741de0VVhTtAj1uzsFUnSDCfhXP/Z6Ti0x5815Ob8hNSj8QuX MXgg== X-Forwarded-Encrypted: i=1; AHgh+RokvehbtX2pw9YVKladRSPi7XkQxVpT4R1ulHMsjaSuGw2PXX/hGibmOr56Mu8FZSexYOSfQphrkJO/@vger.kernel.org X-Gm-Message-State: AOJu0YxcdbppVPHU1nAO3/9UwPnWmk6DBhp//DnIZ/ZApkZkGqN+XxyY qjD29xELDSwfRtz7AWU4aV2XUlinBozk//fWR9ywe/3Y2lISBGU/o8sn X-Gm-Gg: AfdE7ck5/uZykyPf4woe7hO/TveMbeVEggvAhlUoP/BVL5EiCbNB6B7gUxlLCgKr/4b 9e+NaGYu7XzZXiK+BrizhJTtfe3GmtFu10Wyjc9R5x4vcxgz9IuooRLCdcluxqhxKd8G1qtpAzO mm4V/2kMJrZhLprI8TyMe0PzTRbYQ+lQA87nobi5dWjxZrlR89u3NvhTj+XOVNJgIARUt9joY8L RX/y28crF+bvEQeVj5+xbrSlNw/SJwtxRH1VKFVI8KyUhpvC+dOFhSb7Fz059ZKn71kagFM8tav 4+gB4Ckqzb+GFMZ1An640azk8sz6EVjMGs6VkRpj9l41i9wHcdgLXapXI00FnD3+YX7aUjUDS0B T/sTAGgAvqA9ohBWGqnN68W4MeCNxOFzsAMWGyY8nhnjgUhOYK/DzpcHfsJVnbJJLMan28uLjnl tZ/lJLDDROd6MEf1RtF/12rQVjExl8ZcmpuT18BSxQdNvMRJVk8LRBSn7UO9fRuNLQDTPSipuGm L5UnzZV X-Received: by 2002:a05:600c:19d0:b0:492:6efc:7c60 with SMTP id 5b1f17b1804b1-49518308220mr36197365e9.28.1784030339968; Tue, 14 Jul 2026 04:58:59 -0700 (PDT) Received: from Ansuel-XPS24.localdomain (host-95-248-227-210.retail.telecomitalia.it. [95.248.227.210]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-493fd3ccfd4sm180531655e9.2.2026.07.14.04.58.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2026 04:58:59 -0700 (PDT) From: Christian Marangi To: Bjorn Helgaas , Lorenzo Pieralisi , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Ryder Lee , Michael Turquette , Stephen Boyd , Brian Masney , Philipp Zabel , Matthias Brugger , AngeloGioacchino Del Regno , Christian Marangi , Jianjun Wang , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH v4 2/4] clk: en7523: add support for dedicated PCIe PERSTOUT reset Date: Tue, 14 Jul 2026 13:58:44 +0200 Message-ID: <20260714115848.8537-3-ansuelsmth@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260714115848.8537-1-ansuelsmth@gmail.com> References: <20260714115848.8537-1-ansuelsmth@gmail.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add support for resetting the PCIe lines with the PERSTOUT reset. These special reset are controlled by the PCIC register and are specific to each of the 3 PCIe lines. Notice that reset logic is inverted for these bit where 0 is assert and 1 deassert. This is intenrally handled in the reset function. PCI enable/disable are updated to drop PERSTOUT bits in favor dedicated reset handling. Signed-off-by: Christian Marangi --- drivers/clk/clk-en7523.c | 39 ++++++++++++++++++++++++++++----------- 1 file changed, 28 insertions(+), 11 deletions(-) diff --git a/drivers/clk/clk-en7523.c b/drivers/clk/clk-en7523.c index 1ab0e2eca5d3..c9b21d9bf2f3 100644 --- a/drivers/clk/clk-en7523.c +++ b/drivers/clk/clk-en7523.c @@ -338,6 +338,7 @@ static const struct en_clk_desc en7581_base_clks[] = { static const u16 en7581_rst_ofs[] = { REG_RST_CTRL2, REG_RST_CTRL1, + REG_NP_SCU_PCIC, }; static const u16 en751221_rst_ofs[] = { @@ -450,6 +451,11 @@ static const u16 en7581_rst_map[] = { [EN7581_CPU_TIMER_RST] = RST_NR_PER_BANK + 28, [EN7581_PCIE_HB_RST] = RST_NR_PER_BANK + 29, [EN7581_XPON_MAC_RST] = RST_NR_PER_BANK + 31, + + /* RST_PCIC */ + [EN7581_PCIC_PERSTOUT0_RST] = 2 * RST_NR_PER_BANK + 29, + [EN7581_PCIC_PERSTOUT1_RST] = 2 * RST_NR_PER_BANK + 26, + [EN7581_PCIC_PERSTOUT2_RST] = 2 * RST_NR_PER_BANK + 16, }; static const u16 en751221_rst_map[] = { @@ -635,9 +641,7 @@ static int en7581_pci_enable(struct clk_hw *hw) void __iomem *np_base = cg->base; u32 val, mask; - mask = REG_PCI_CONTROL_REFCLK_EN0 | REG_PCI_CONTROL_REFCLK_EN1 | - REG_PCI_CONTROL_PERSTOUT1 | REG_PCI_CONTROL_PERSTOUT2 | - REG_PCI_CONTROL_PERSTOUT; + mask = REG_PCI_CONTROL_REFCLK_EN0 | REG_PCI_CONTROL_REFCLK_EN1; val = readl(np_base + REG_PCI_CONTROL); writel(val | mask, np_base + REG_PCI_CONTROL); @@ -650,9 +654,7 @@ static void en7581_pci_disable(struct clk_hw *hw) void __iomem *np_base = cg->base; u32 val, mask; - mask = REG_PCI_CONTROL_REFCLK_EN0 | REG_PCI_CONTROL_REFCLK_EN1 | - REG_PCI_CONTROL_PERSTOUT1 | REG_PCI_CONTROL_PERSTOUT2 | - REG_PCI_CONTROL_PERSTOUT; + mask = REG_PCI_CONTROL_REFCLK_EN0 | REG_PCI_CONTROL_REFCLK_EN1; val = readl(np_base + REG_PCI_CONTROL); writel(val & ~mask, np_base + REG_PCI_CONTROL); usleep_range(1000, 2000); @@ -754,14 +756,21 @@ static int en7523_reset_update(struct reset_controller_dev *rcdev, unsigned long id, bool assert) { struct en_rst_data *rst_data = container_of(rcdev, struct en_rst_data, rcdev); - void __iomem *addr = rst_data->base + rst_data->bank_ofs[id / RST_NR_PER_BANK]; + u32 offset = rst_data->bank_ofs[id / RST_NR_PER_BANK]; + void __iomem *addr = rst_data->base + offset; + bool inverted = false; u32 val; + /* For PCIC reset logic is inverted, 0:assert 1:deassert*/ + if (offset == REG_NP_SCU_PCIC) + inverted = true; + val = readl(addr); + val &= ~BIT(id % RST_NR_PER_BANK); if (assert) - val |= BIT(id % RST_NR_PER_BANK); + val |= inverted ? 0 : BIT(id % RST_NR_PER_BANK); else - val &= ~BIT(id % RST_NR_PER_BANK); + val |= inverted ? BIT(id % RST_NR_PER_BANK) : 0; writel(val, addr); return 0; @@ -783,9 +792,17 @@ static int en7523_reset_status(struct reset_controller_dev *rcdev, unsigned long id) { struct en_rst_data *rst_data = container_of(rcdev, struct en_rst_data, rcdev); - void __iomem *addr = rst_data->base + rst_data->bank_ofs[id / RST_NR_PER_BANK]; + u32 offset = rst_data->bank_ofs[id / RST_NR_PER_BANK]; + void __iomem *addr = rst_data->base + offset; + bool inverted = false; + u32 val; + + /* For PCIC reset logic is inverted, 0:assert 1:deassert*/ + if (offset == REG_NP_SCU_PCIC) + inverted = true; - return !!(readl(addr) & BIT(id % RST_NR_PER_BANK)); + val = readl(addr) & BIT(id % RST_NR_PER_BANK); + return inverted ? !val : !!val; } static int en7523_reset_xlate(struct reset_controller_dev *rcdev, -- 2.53.0