From: sashiko-bot@kernel.org
To: "Abel Vesa" <abel.vesa@oss.qualcomm.com>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: remoteproc: qcom,milos-pas: Add Eliza CDSP compatible
Date: Tue, 14 Jul 2026 12:29:57 +0000 [thread overview]
Message-ID: <20260714122958.D6CED1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260714-remoteproc-eliza-cdsp-v1-1-32eb7a1f2c59@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Legacy compatible strings silently allow 3 `memory-region` items because they lack an explicit `maxItems: 2` constraint.
--
--- Patch [1]: [PATCH 1/2] dt-bindings: remoteproc: qcom,milos-pas: Add Eliza CDSP compatible ---
commit 035d1273c9ae4354ae4a87c41fd4d9ad57c5bddc
Author: Abel Vesa <abel.vesa@oss.qualcomm.com>
dt-bindings: remoteproc: qcom,milos-pas: Add Eliza CDSP compatible
This commit documents the compatible string for the CDSP Peripheral
Authentication Service on the Eliza SoC. It reworks the schema to accommodate
a third memory region (DSM) and the NSP power domain.
> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,milos-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,milos-pas.yaml
> index 99d7337e58ec5..3ee7be3304c6f 100644
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,milos-pas.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,milos-pas.yaml
[ ... ]
> @@ -97,7 +99,26 @@ allOf:
> minItems: 2
> firmware-name:
> minItems: 2
> - else:
> +
[Severity: Medium]
Since adding the third item to the memory-region properties implicitly
raises the maximum limit to 3 globally, should maxItems: 2 be explicitly
specified here for qcom,eliza-adsp-pas and the other legacy devices?
Without an explicit constraint, won't dt_binding_check silently allow
misconfigured device trees for these older devices to incorrectly specify
3 memory regions?
> + - if:
> + properties:
> + compatible:
> + enum:
> + - qcom,eliza-cdsp-pas
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260714-remoteproc-eliza-cdsp-v1-0-32eb7a1f2c59@oss.qualcomm.com?part=1
next prev parent reply other threads:[~2026-07-14 12:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-14 12:24 [PATCH 0/2] remoteproc: qcom: pas: Add support for CDSP on Eliza SoC Abel Vesa
2026-07-14 12:24 ` [PATCH 1/2] dt-bindings: remoteproc: qcom,milos-pas: Add Eliza CDSP compatible Abel Vesa
2026-07-14 12:29 ` sashiko-bot [this message]
2026-07-14 12:24 ` [PATCH 2/2] remoteproc: qcom: pas: Add Eliza CDSP support Abel Vesa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260714122958.D6CED1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=abel.vesa@oss.qualcomm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox