Re: [PATCH 3/6] drm/panel: simple: Add waiken WKS101WX001-WCT support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Mismatch in physical height specification between the display mode and the panel description.
--

--- Patch [3]: [PATCH 3/6] drm/panel: simple: Add waiken WKS101WX001-WCT support ---
commit 3308303d1b9690b2cd880fcdaaf60adb3ce4cea7
Author: Frank Li <Frank.Li@nxp.com>

drm/panel: simple: Add waiken WKS101WX001-WCT support

This commit adds support for the waiken WKS101WX001-WCT panel, which is an
industrial-grade 10.1-inch IPS TFT LCD capacitive touch screen display
module.

> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index c09bf3db5e78a..26fd150aa4454 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c

[ ... ]

> +static const struct drm_display_mode waiken_101wx001_mode = {
> +	.clock = 71100,
> +	.hdisplay = 1280,
> +	.hsync_start = 1280 + 70,
> +	.hsync_end = 1280 + 70 + 10,
> +	.htotal = 1280 + 70 + 10 + 80,
> +	.vdisplay = 800,
> +	.vsync_start = 800 + 10,
> +	.vsync_end = 800 + 10 + 3,
> +	.vtotal = 800 + 10 + 3 + 10,
> +	.width_mm = 217,
> +	.height_mm = 135,
> +	.flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
> +};
> +
> +static const struct panel_desc waiken_101wx001_panel = {
> +	.modes = &waiken_101wx001_mode,
> +	.num_modes = 1,
> +	.bpc = 6,
> +	.size = {
> +		.width = 217,
> +		.height = 136,

[Severity: Low]
Is there a reason the physical height differs between the display mode and the
panel descriptor?

In waiken_101wx001_mode, height_mm is set to 135, but here in
waiken_101wx001_panel the size.height is set to 136. This mismatch will
cause userspace applications querying DRM properties to receive inconsistent
dimension values depending on whether they read connector or mode properties.

> +	},
> +	.bus_format = MEDIA_BUS_FMT_RGB666_1X18,
> +	.connector_type = DRM_MODE_CONNECTOR_DPI,
> +	.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE,
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260714-dxl_lcdif-v1-0-6761a8a6592b@nxp.com?part=3