Re: [PATCH 1/3] dt-bindings: clock: qcom: Move x1e80100 TCSR to own binding

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The new `qcom,x1e80100-tcsr.yaml` binding defines hardware provider capabilities (`#clock-cells` and `#reset-cells`) and mentions power domains in the description, but fails to include these cell properties in the `required` list. This violates the DT binding subsystem guidelines which mandate that hardware variant provider capabilities must be documented and required.
--

--- Patch [1]: [PATCH 1/3] dt-bindings: clock: qcom: Move x1e80100 TCSR to own binding ---
commit fdaf487663a160c0f437f63e82dda477ea7a20b5
Author: Qiang Yu <qiang.yu@oss.qualcomm.com>

dt-bindings: clock: qcom: Move x1e80100 TCSR to own binding

The QREF block supplies reference clocks to PCIe/USB/UFS PHYs and requires
dedicated LDO supplies. This commit moves the x1e80100 TCSR interface to its
own dedicated binding file to document these supply properties.

> diff --git a/Documentation/devicetree/bindings/clock/qcom,x1e80100-tcsr.yaml b/Documentation/devicetree/bindings/clock/qcom,x1e80100-tcsr.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/qcom,x1e80100-tcsr.yaml
[ ... ]
> +  '#clock-cells':
> +    const: 1
> +
> +  '#reset-cells':
> +    const: 1
[ ... ]
> +required:
> +  - compatible
> +  - clocks
> +  - vdda-qrefrpt0-0p9-supply

[Severity: Medium]
Will this omission allow incomplete device trees to silently pass validation?

The new binding defines #clock-cells and #reset-cells as properties, but they
are omitted from this required list. The device tree binding guidelines
mandate that when hardware variants introduce provider capabilities (such as
clocks and resets), the corresponding cell properties must be explicitly
required.

Without these in the required list, incomplete device tree nodes could pass
dt_binding_check validation, potentially leading to runtime failures or probe
deferrals when drivers or dependent subsystems attempt to use the undocumented
functionality.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260714-hamoa_tcsr_qref_0714_2-v1-0-13047922a376@oss.qualcomm.com?part=1