Re: [PATCH 2/3] dt-bindings: iio: light: ltr501: Add ltr329 compatible

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The schema fails to disallow the `interrupts` property for the `liteon,ltr329` compatible string, despite the device explicitly lacking interrupt support.
--

--- Patch [2]: [PATCH 2/3] dt-bindings: iio: light: ltr501: Add ltr329 compatible ---
commit 5d6bf65302b94ef38e976c911c22a66db543f0fe
Author: Esben Haabendal <esben@geanix.com>

dt-bindings: iio: light: ltr501: Add ltr329 compatible

LTR-329ALS-01 is an ambient light sensor similar to LTR-303ALS-01, but
without interrupt support.

> diff --git a/Documentation/devicetree/bindings/iio/light/liteon,ltr501.yaml b/Documentation/devicetree/bindings/iio/light/liteon,ltr501.yaml
> index ab9bb68dd7363..76e81eba7ea4a 100644
> --- a/Documentation/devicetree/bindings/iio/light/liteon,ltr501.yaml
> +++ b/Documentation/devicetree/bindings/iio/light/liteon,ltr501.yaml
> @@ -19,6 +19,7 @@ properties:
>        - liteon,ltr559
>        - liteon,ltr301
>        - liteon,ltr303
> +      - liteon,ltr329
>  
>    reg:
>      maxItems: 1

[Severity: Medium]
Since the commit message states this sensor operates without interrupt support,
should the schema disallow the interrupts property for this compatible string?

Adding the compatible string directly to the main enum allows a device tree to
specify an interrupt for liteon,ltr329 without being caught during schema
validation.

Would it make sense to add an if/then conditional block to restrict the
interrupts property when the compatible string is liteon,ltr329 to prevent
this regression?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260715-liteon-ltr329-v1-0-31f027051594@geanix.com?part=2