Re: [PATCH v2 2/4] dt-bindings: hwmon: Add Kandou KB9002

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The `reg` property is missing the `maxItems: 1` constraint and incorrectly applies `minimum` and `maximum` constraints directly to the array instance.
- [Low] The device tree binding for a PCIe retimer is incorrectly placed in the hwmon/ directory.
--

--- Patch [2]: [PATCH v2 2/4] dt-bindings: hwmon: Add Kandou KB9002 ---
commit e4c6f2bbc23572a071a648919c1c0c0e4520ad76
Author: Andy Chung <Andy.Chung@amd.com>

dt-bindings: hwmon: Add Kandou KB9002

Add device tree bindings for the Kandou KB9002 PCIe 5.0 retimer, an
SMBus target that exposes an aggregated die temperature.

> diff --git a/Documentation/devicetree/bindings/hwmon/kandou,kb9002.yaml b/Documentation/devicetree/bindings/hwmon/kandou,kb9002.yaml
> new file mode 100644
> index 0000000000000..67859e9d63c25
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/kandou,kb9002.yaml
> @@ -0,0 +1,45 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/kandou,kb9002.yaml#

[Severity: Low]
Does this binding belong in the hwmon directory? Since this device is
primarily an 8-lane PCIe 5.0 retimer rather than a dedicated hardware
monitor, it seems like the binding should be placed in a physical
category directory like phy/ or pci/ instead.

[ ... ]

> +properties:
> +  compatible:
> +    const: kandou,kb9002
> +
> +  reg:
> +    minimum: 0x20
> +    maximum: 0x27

[Severity: Medium]
Can this correctly constrain the I2C address? The reg property evaluates
as an array, so omitting maxItems: 1 allows multiple addresses to pass
validation. 

Furthermore, applying numeric constraints directly to the array rather
than its items causes them to be silently ignored by the validator,
allowing out-of-range addresses to pass.

> +
> +required:
> +  - compatible
> +  - reg

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260715-kb9002-upstream-v2-0-2fd390383da5@amd.com?part=2