Re: [PATCH v2 04/10] dt-bindings: arm: apple: apple,pmgr: Add t6030 and t6031 compatibles

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Incomplete binding schema update: missing 'apple,t6030-pmgr-pwrstate' and 'apple,t6031-pmgr-pwrstate' in companion schema 'apple,pmgr-pwrstate.yaml'.
--

--- Patch [4]: [PATCH v2 04/10] dt-bindings: arm: apple: apple,pmgr: Add t6030 and t6031 compatibles ---
commit 8f34f4075b928942fd23fe22c7c37b31b25aa7ec
Author: Janne Grunau <j@jannau.net>

dt-bindings: arm: apple: apple,pmgr: Add t6030 and t6031 compatibles

This commit adds per-SoC compatibles for M3 Pro, Max, and Ultra to the
Apple PMGR block binding.

> diff --git a/Documentation/devicetree/bindings/arm/apple/apple,pmgr.yaml b/Documentation/devicetree/bindings/arm/apple/apple,pmgr.yaml
> --- a/Documentation/devicetree/bindings/arm/apple/apple,pmgr.yaml
> +++ b/Documentation/devicetree/bindings/arm/apple/apple,pmgr.yaml
> @@ -38,6 +38,8 @@ properties:
>        - items:
>            - enum:
>                - apple,t6020-pmgr
> +              - apple,t6030-pmgr
> +              - apple,t6031-pmgr

[Severity: Low]
Should the companion schema Documentation/devicetree/bindings/power/apple,pmgr-pwrstate.yaml
also be updated to include apple,t6030-pmgr-pwrstate and apple,t6031-pmgr-pwrstate?

While this commit adds the parent PMGR compatibles, missing the corresponding
strings in the companion schema might cause make dtbs_check to be incomplete
or fail for power domain subnodes in upcoming device trees for these SoCs.

For example, looking at the companion schema:

Documentation/devicetree/bindings/power/apple,pmgr-pwrstate.yaml:
      - items:
          - enum:
              - apple,t6020-pmgr-pwrstate
              - apple,t8122-pmgr-pwrstate
          - const: apple,t8103-pmgr-pwrstate

Could the t6030 and t6031 generation strings be added to this enum alongside
t6020 so that power-controller subnodes validate properly?

>                - apple,t8122-pmgr
>            - const: apple,t8103-pmgr
>            - const: syscon

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260715-apple-t603x-initial-devices-v2-0-df65b2485710@jannau.net?part=4