Re: [PATCH v6 1/5] spi: dt-bindings: Add spi-device-addr peripheral property

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `spi-device-addr` array property groups multiple physical chips under a single Device Tree node, which violates core DT architecture and precludes describing per-chip resources.
--

--- Patch [1]: [PATCH v6 1/5] spi: dt-bindings: Add spi-device-addr peripheral property ---
commit 039a81f5133684e72f9b6f61fd5df1550f9b8b54
Author: Janani Sunil <janani.sunil@analog.com>

spi: dt-bindings: Add spi-device-addr peripheral property

This commit adds a generic spi-device-addr property to describe multiple
hardware addresses for SPI devices that share a single chip select. The
property is defined as a uint32-array to be placed on the SPI peripheral
node.

> diff --git a/Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml b/Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml
> --- a/Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml
> +++ b/Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml

[ ... ]

> @@ -142,6 +142,11 @@ properties:
>      minItems: 2
>      maxItems: 4
>  
> +  spi-device-addr:
> +    $ref: /schemas/types.yaml#/definitions/uint32-array
> +    description:
> +      Device address used when multiple peripherals share a single chip select.

[Severity: Medium]
Does grouping multiple physical chips under a single Device Tree node using an
array property conflict with core DT architecture?

If multiple addresses are listed here, it becomes impossible to describe
distinct per-chip hardware resources, such as individual interrupts, clocks,
or power supplies for those physical chips.

Would it be more appropriate to model the shared CS as a bridge or bus node
with #address-cells = <1>, and represent each physical chip as a distinct
child node with its own reg and discrete properties? 

Since Device Tree bindings form a permanent ABI, establishing this array
pattern might permanently constrain drivers needing to represent per-chip
resources on shared chip selects.

> +
>    st,spi-midi-ns:
>      deprecated: true
>      description: |

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260715-ad5529r-driver-v6-0-cfdf8b9f5ee3@analog.com?part=1