Re: [PATCH v2 2/3] soc: mediatek: pwrap: use correct log level

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] Child devices created by `of_platform_populate()` are not cleaned up on driver unbind, leading to orphaned devices and potential Use-After-Free.
--

--- Patch [2]: [PATCH v2 2/3] soc: mediatek: pwrap: use correct log level ---
commit ce26f7b3ff3bc3d17adce977d882bf0f6118ba23
Author: Roman Vivchar <rva333@protonmail.com>

soc: mediatek: pwrap: use correct log level

This commit simplifies the error paths in the pwrap driver probe function
by replacing dev_dbg calls with dev_err_probe, ensuring the correct log
level is used on failure.

> diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
> --- a/drivers/soc/mediatek/mtk-pmic-wrap.c
> +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c

[ ... ]

> @@ -2593,11 +2584,9 @@ static int pwrap_probe(struct platform_device *pdev)
>  		return PTR_ERR(wrp->regmap);
>  
>  	ret = of_platform_populate(np, NULL, NULL, wrp->dev);

[Severity: High]
This is a pre-existing issue, but does this code leave child devices
populated on driver unbind?

Since devm_regmap_init() is used earlier, the regmap will be automatically
freed when the driver unbinds. If devm_of_platform_populate() isn't used
here, will child PMIC drivers remain bound and attempt to use the freed
parent regmap, leading to a use-after-free?

> -	if (ret) {
> -		dev_dbg(wrp->dev, "failed to create child devices at %pOF\n",
> -				np);
> -		return ret;
> -	}
> +	if (ret)
> +		return dev_err_probe(wrp->dev, ret,
> +				     "failed to create child devices at %pOF\n", np);
>  
>  	return 0;
>  }

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260715-6572-pwrap-v2-0-bea1d801c81b@protonmail.com?part=2