From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A110647B423 for ; Wed, 15 Jul 2026 12:53:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784120010; cv=none; b=T6Dkx8giU7UKwvrsf0thxOGiLfQt+/ot3ordZ3iXEk2rUrFRAYOIWGtwXkPVFknqMZObX/jWZLtWlvpTDwP2gw1ERG0Z0AQmWX4lreDls+9OIULxxzlsl0TtrLtDMshD9ZjQAUTuKm1+eP+P/MoFVKI/RpRPGZYamOfQqGHD9iQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784120010; c=relaxed/simple; bh=hWz5XuNNH6IsELRjB/pr17epEqauWvX8kaZ2l3hPuZ8=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Z6oaHFrMSkC3e1CsL+xdgTRPK5WFp6kcvQTqvVZBm/LzMzZD81OAGIJp/PLqd7/NjuPYQKftNg4latnMXuTEcR1KPpiXstAIrQoBY/WBNIUGvKRJxFnl1zR8bmzbVLgt4yn/hDAMwGAc1NAOxBJGrWN9cXYl0QhqgI6um4r13qg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=g+5IplrS; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="g+5IplrS" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-493e8d4f4dcso40926365e9.0 for ; Wed, 15 Jul 2026 05:53:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784120007; x=1784724807; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=hP7wIP17IllMUj2NiPW3mgVs5U+s5JJ48RRRp+m/d5g=; b=g+5IplrSq+d8mCe7g/wdx9efOv03kjXKMZe2lacoSEExozbWiZUzw7JI6yfytFDaK5 NtPLjisa8F2UPv3tkmfzqbBxuJv2sVrjNgcSkEH7bE0ujoj2M3/O+ozAp9HQDpXhBoDY ek093hwF6fCXcCfozmx3+p6++b1qUgyqZz8tQoKjohdjgvk+4vPJsgzIcJw5hF5Stgcd Qn2VO5x9jXv49IRr/8KuRRhRmjLkpDlSXdeckWL+Om5w5HXP/Ano5CRTzdtDP9XbtJz8 HCu4U3bjgnLpOAcNsR7VpbPbRhao6jAnZnv/4qdWaK5ATfoNrjAhRyt1aJxZxWqasaZK NFyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784120007; x=1784724807; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=hP7wIP17IllMUj2NiPW3mgVs5U+s5JJ48RRRp+m/d5g=; b=IdQcRRwBktvDWmARCtDscAK47Ao2vbgEmkMtw6T6zPE5emrxRO5B3B1ErD5VHgEKMw ws7RVcjsiLk3DW4Fl8HHy2TfGuhDpsOZM+Kc8x/4yBTzQAqHz4MshC3uP4NMdssd5Scz 5CqzKLAtxRXyp5XrH0S3xLlKtdC59LXJ5j5ZMumllxvFPvIEs+2GTbygoVOIanQ8JDNJ L9n47AuQYlia3KmDdYlSvs8/Z00tGq6Has8nCW4rddDVjNodlkyPAaAfVNXS0490r73k iRF4f6VaZi2491NYTrJjGcin2cXfoqCwZ4QwyKRhkgwMQWb+A4dNSaZWgXuTlz0I6/1M KJcA== X-Forwarded-Encrypted: i=1; AHgh+Rr/DVGUKauT/TzGjHckMt/IBqnKFTxdN16or+epLPaMPR9ss7gygOCUpOXmjqb553j2HaIzjsPIidH1@vger.kernel.org X-Gm-Message-State: AOJu0Yy7ZVYUdxKvNPR8/r4VUP8rsi+aF6zpefMiOMAMyzBbpLo6fimw 6072CtbmKhw6QzsoxaNSPbXUQ4ngD1CWYSTljoKOz+yjuIM/hopEixvo X-Gm-Gg: AfdE7cmuFDtTeTISd/opeqGCwMKicesUuszCx2Nc6ZlwOve+0gXjJR5gsjbQiMKW7Fn X8jsRhAnWgjOoZ7nTS9Ong0J2E7WzYvcmKckoVAyg4m6Ih7kMtoYky36GTlOcZyLfxCgkTwZVus lO3EuP6U9lndvYoS3gGA7Xknz8jTumzv6MZtb4LRYbBBvDsdx6HfP+PWWdiSACRClfsQ2lkhBo+ CWOe4SMoF19RxShTA4iABpo0LwTZq+C3+E0aPu2sCmruzl4JqngvSDYFevdHJ7F1FzIzobYib1V E5wItWato+VgJu2QA6SAWOkDUriacG9qYU184vwVWqurPiwNFLpJMUE3N3F2lI7xuCU15BqWH1N DIkdQWlBfQcF5BT019MpfYdSWarQr7pwYmHZg15mCNUYsua61PQUdo1p1VJWrNY9MwhNCB8Y+OY ypfBM2JlrzszO3sJ7MsrWODh9nDvOHy2o43BnUDTotdMouo8Da10/QUp9EoMdNxn0K9knISIycK e/AJYD43L8cCf5LfUuXEZ9uqdZoN7BYo4IhYuyE11caOPdLnGm7KmHVI796oOg2Sfd8j3i2+5bU fTIe+l/faUu/7dqjXbZCzvJI17pfzMc03tAt6fu1XzZWKNBdSjkcgNHeXuyJj8z7ebW2p+P38Em 3xQy9/cwyS8v5xzs/HQ/qm9U= X-Received: by 2002:a05:600c:37c9:b0:493:bc4a:fb55 with SMTP id 5b1f17b1804b1-4953c28951fmr30630675e9.38.1784120006763; Wed, 15 Jul 2026 05:53:26 -0700 (PDT) Received: from localhost (90-182-112-124.rcp.o2.cz. [90.182.112.124]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4953c6ff429sm38564585e9.1.2026.07.15.05.53.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 05:53:26 -0700 (PDT) Date: Wed, 15 Jul 2026 14:53:24 +0200 From: Joshua Crofts To: Esben Haabendal Cc: Jonathan Cameron , David Lechner , Nuno =?ISO-8859-1?Q?S=E1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Nikita Travkin , Maslov Dmitry , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/4] iio: light: ltr501: Add ltr329 driver support Message-ID: <20260715145324.000005c6@gmail.com> In-Reply-To: <20260715-liteon-ltr329-v2-3-d18af55edab5@geanix.com> References: <20260715-liteon-ltr329-v2-0-d18af55edab5@geanix.com> <20260715-liteon-ltr329-v2-3-d18af55edab5@geanix.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.51; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 15 Jul 2026 14:27:25 +0200 Esben Haabendal wrote: > This adds support for the LTR-329ALS-01 chip, which is similar to > LTR-303ALS-01, except for interrupt, which LTR-329ALS-01 chip does not > have. > > Signed-off-by: Esben Haabendal > --- > drivers/iio/light/ltr501.c | 33 +++++++++++++++++++++++++++++++++ > 1 file changed, 33 insertions(+) > > diff --git a/drivers/iio/light/ltr501.c b/drivers/iio/light/ltr501.c > index 7d045be78c6d..379e57ac5f5b 100644 > --- a/drivers/iio/light/ltr501.c > +++ b/drivers/iio/light/ltr501.c > @@ -15,6 +15,7 @@ > #include > #include > #include > +#include // for ARRAY_SIZE Just a small nit, even though the list isn't exactly ordered, please try to add the new include approximately where it would be if ordered, i.e. array_size.h goes to the top. Additionally, you don't need to add a comment. Everything else seems fine otherwise. -- Kind regards CJD