Re: [PATCH 1/2] dt-bindings: media: i2c: Add imx708 image sensor

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The IMX708 device tree binding strictly prohibits standard camera properties like `rotation`, `orientation`, and `lens-focus` by omitting the common video-interface-devices schema reference.
--

--- Patch [1]: [PATCH 1/2] dt-bindings: media: i2c: Add imx708 image sensor ---
commit 6db06a28573083737d3c74ac1c5d01840d0d4fc3
Author: Jai Luthra <jai.luthra@ideasonboard.com>

dt-bindings: media: i2c: Add imx708 image sensor

This commit adds the device tree binding schema for the Sony IMX708 CMOS
sensor. It defines the I2C configuration, required power supplies, and
MIPI CSI-2 interface properties.

> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx708.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx708.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx708.yaml

[ ... ]

> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - vdig-supply
> +  - vana1-supply
> +  - vana2-supply
> +  - vddl-supply
> +  - port
> +
> +additionalProperties: false

[Severity: Medium]
Will this strict additionalProperties constraint incorrectly reject standard
camera properties like rotation or orientation?

Because this binding in Documentation/devicetree/bindings/media/i2c/sony,imx708.yaml
does not reference the common video-interface-devices schema, standard device
tree properties describing the physical mounting of the sensor will fail
validation during dt_binding_check.

Should this binding include an allOf reference to the common schema and use
unevaluatedProperties instead of additionalProperties at the top level?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260715-imx708-v1-0-1f36f54e14d4@ideasonboard.com?part=1