Re: [PATCH v2 2/2] clk: qcom: Add support for videocc driver on Qualcomm Maili SoC

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The Kconfig symbol CLK_MAILI_VIDEOCC incorrectly selects CLK_HAWI_GCC instead of a Maili-specific GCC.
--

--- Patch [2]: [PATCH v2 2/2] clk: qcom: Add support for videocc driver on Qualcomm Maili SoC ---
commit aa207bbe10b80dabb8f5f04613d0738a36c1da76
Author: Jagadeesh Kona <jagadeesh.kona@oss.qualcomm.com>

clk: qcom: Add support for videocc driver on Qualcomm Maili SoC

This commit adds the video clock controller driver for the Qualcomm Maili
SoC. It allows video clients to request video clock controller clocks.

> diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
> index 63f271aff1771..690f0b6fe227c 100644
> --- a/drivers/clk/qcom/Kconfig
> +++ b/drivers/clk/qcom/Kconfig
[ ... ]
> @@ -181,6 +181,16 @@ config CLK_KAANAPALI_VIDEOCC
>  	  Say Y if you want to support video devices and functionality such as
>  	  video encode/decode.
>  
> +config CLK_MAILI_VIDEOCC
> +	tristate "Maili Video Clock Controller"
> +	depends on ARM64 || COMPILE_TEST
> +	select CLK_HAWI_GCC

[Severity: Medium]
Is this select statement a copy-paste error? It appears to pull in the GCC
driver for the Hawi SoC instead of the Maili-specific clock controller.

Should this be selecting the Maili GCC driver instead to ensure the parent
clock controller is present during runtime?

> +	default m if ARCH_QCOM
> +	help
> +	  Support for the video clock controller on Maili devices.
> +	  Say Y if you want to support video devices and functionality such as
> +	  video encode/decode.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260716-maili_videocc-v2-0-7ed5ab140770@oss.qualcomm.com?part=2