From: sashiko-bot@kernel.org
To: "Jiaxing Hu" <gahing@gahingwoo.com>
Cc: conor+dt@kernel.org, robh@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/2] arm64: dts: rockchip: Add ArmSoM CM5 and CM5-IO
Date: Thu, 16 Jul 2026 07:08:22 +0000 [thread overview]
Message-ID: <20260716070823.09F011F000E9@smtp.kernel.org> (raw)
In-Reply-To: <0b2212fb-8149-453c-bdef-dacbf2263f1a@smtp-relay.sendinblue.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The ES8388 audio codec is documented in the file comments but its device tree nodes are missing.
--
--- Patch [2]: [PATCH v2 2/2] arm64: dts: rockchip: Add ArmSoM CM5 and CM5-IO ---
commit e190cae752b4a73c5373d9576341bafa7b3f0b4f
Author: Jiaxing Hu <gahing@gahingwoo.com>
arm64: dts: rockchip: Add ArmSoM CM5 and CM5-IO
Add the ArmSoM CM5, an RK3576 compute module (rk3576-armsom-cm5.dtsi),
and its CM5-IO carrier (rk3576-armsom-cm5-io.dts). The carrier adds HDMI, a
GbE RJ45, two USB-A ports behind a USB3 hub, USB-C with FUSB302 and DP
alt-mode, a PCIe 2.0 x1 M.2 slot, microSD, status LEDs and a 40-pin
header.
> diff --git a/arch/arm64/boot/dts/rockchip/rk3576-armsom-cm5-io.dts b/arch/arm64/boot/dts/rockchip/rk3576-armsom-cm5-io.dts
> new file mode 100644
> index 0000000000000..79a903585197c
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3576-armsom-cm5-io.dts
[ ... ]
> +/*
> + * I2C0: ES8388 audio codec @ 0x10, FUSB302 USB-C PD controller @ 0x22.
> + * Pinctrl i2c0m1 (GPIO0 PC4 SCL / GPIO0 PC5 SDA).
> + */
> +&i2c0 {
> + status = "okay";
> + pinctrl-names = "default";
> + pinctrl-0 = <&i2c0m1_xfer>;
> +
> + usbc0: usb-typec@22 {
[Severity: Medium]
Is the ES8388 audio codec node missing from this bus? Both the file header
and the comment above indicate it should be on i2c0 at address 0x10, but
only the FUSB302 USB-C PD controller node is present.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260716065548.2466198-1-gahing@gahingwoo.com?part=2
next prev parent reply other threads:[~2026-07-16 7:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260716065548.2466198-1-gahing@gahingwoo.com>
2026-07-16 6:55 ` [PATCH v2 1/2] dt-bindings: arm: rockchip: Add ArmSoM CM5 and CM5-IO Jiaxing Hu
2026-07-16 6:55 ` [PATCH v2 2/2] arm64: dts: " Jiaxing Hu
2026-07-16 7:06 ` sashiko-bot
[not found] ` <0b2212fb-8149-453c-bdef-dacbf2263f1a@smtp-relay.sendinblue.com>
2026-07-16 7:08 ` sashiko-bot [this message]
[not found] ` <a86b8b22-6216-4926-a82f-9d4bd15cc397@smtp-relay.sendinblue.com>
2026-07-16 7:12 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260716070823.09F011F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gahing@gahingwoo.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox