Re: [PATCH 2/3] dt-bindings: iio: dac: add adi,ad5710r.yaml

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The `minimum` and `maximum` constraints on the channel `reg` property are incorrectly wrapped in an `items` list schema, causing them to be silently ignored by the JSON Schema validator.
- [Medium] The binding introduces a custom global property `adi,range-double` to configure the voltage range, which contradicts the hardware's per-channel capability and ignores standard IIO properties.
--

--- Patch [2]: [PATCH 2/3] dt-bindings: iio: dac: add adi,ad5710r.yaml ---
commit cd748f09cddc4b7eb091c3829a62e52f260a76b0
Author: Kim Seer Paller <kimseer.paller@analog.com>

dt-bindings: iio: dac: add adi,ad5710r.yaml

This commit adds device tree bindings for the Analog Devices AD5710R/AD5711R
8-channel 12-/16-bit Configurable IDAC/VDAC.

> diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5710r.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5710r.yaml
> new file mode 100644
> index 0000000000000..17c1bf0092421
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5710r.yaml
> @@ -0,0 +1,143 @@

[ ... ]

> +description: |
> +  The AD5710R (16-bit) and AD5711R (12-bit) are 8-channel, low-power,
> +  configurable current/voltage output digital-to-analog converters (DACs) with
> +  an on-chip 2.5V, 3ppm/°C reference. Each channel can be independently
> +  configured as a voltage output (0V to VREF or 0V to 2xVREF) or a current

[ ... ]

> +  adi,range-double:
> +    description:
> +      Configure the output range for all channels. If the property is present,
> +      the output will range from 0V to 2Vref. If the property is not present,
> +      the output will range from 0V to Vref.
> +    type: boolean

[Severity: Medium]
The description above explicitly states that "Each channel can be independently
configured as a voltage output (0V to VREF or 0V to 2xVREF)". Does defining
this as a global property artificially limit the hardware's per-channel
capabilities?

Also, since the schema includes dac.yaml, could the standard per-channel
property output-range-microvolt be used instead of defining a custom global
boolean?

[ ... ]

> +patternProperties:
> +  "^channel@[0-7]$":
> +    $ref: /schemas/iio/dac/dac.yaml#
> +    type: object
> +    description:
> +      Represents the external channels which are connected to the DAC.
> +
> +    properties:
> +      reg:
> +        description: Channel number
> +        items:
> +          minimum: 0
> +          maximum: 7

[Severity: Medium]
Are these minimum and maximum constraints incorrectly wrapped in an items
list?

Since JSON Schema ignores numeric keywords when applied to an array type,
will these bounds be silently bypassed during dt_binding_check validation,
allowing out-of-bounds reg values? Should the minimum and maximum
constraints be placed directly under the reg property instead?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260716-iio-ad5710r-upstream-v1-0-e848a4bb701f@analog.com?part=2