Re: [PATCH v2 2/2] ARM: dts: renesas: r9a06g032-rzn1d400-eb: enable GPIOs on CN12

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `pinctrl-0` and `pinctrl-names` properties are placed on the `&gpio2b` child node, where they are silently ignored and violate the DT schema.
--

--- Patch [2]: [PATCH v2 2/2] ARM: dts: renesas: r9a06g032-rzn1d400-eb: enable GPIOs on CN12 ---
commit 273d06c90b129bacc41e41473c190af6105d730d
Author: Wolfram Sang <wsa+renesas@sang-engineering.com>

ARM: dts: renesas: r9a06g032-rzn1d400-eb: enable GPIOs on CN12

This patch adds device tree nodes to enable some GPIOs available on the
CN12 connector independently of switch settings.

> diff --git a/arch/arm/boot/dts/renesas/r9a06g032-rzn1d400-eb.dts b/arch/arm/boot/dts/renesas/r9a06g032-rzn1d400-eb.dts
> index 303b5926d8d17..e6c064bc49c8e 100644
> --- a/arch/arm/boot/dts/renesas/r9a06g032-rzn1d400-eb.dts
> +++ b/arch/arm/boot/dts/renesas/r9a06g032-rzn1d400-eb.dts

[ ... ]

> @@ -53,6 +53,11 @@ led@1 {
>  	};
>  };
>  
> +&gpio2b {
> +	pinctrl-0 = <&pins_gpio2b>;
> +	pinctrl-names = "default";
> +};

[Severity: Medium]
Will these pinctrl settings actually be applied here?

The gpio-dwapb driver parses its child nodes using
device_for_each_child_node_scoped(), but they are not registered as
independent platform devices. Since the Linux driver core only invokes
pinctrl_bind_pins() for devices bound to a driver, won't placing
pinctrl-0 on the &gpio2b child node cause it to be silently ignored and
fail DT schema validation?

Should these properties be placed in the parent &gpio2 node instead?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260716095935.13329-4-wsa+renesas@sang-engineering.com?part=2