Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Shawn Guo" <shengchao.guo@oss.qualcomm.com>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v6 5/6] arm64: dts: qcom: Add device tree for Nord Ride board
Date: Thu, 16 Jul 2026 14:56:37 +0000	[thread overview]
Message-ID: <20260716145638.617FD1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260716142605.2398433-6-shengchao.guo@oss.qualcomm.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Unused SCMI channel 15 enabled in device tree
--

--- Patch [5]: [PATCH v6 5/6] arm64: dts: qcom: Add device tree for Nord Ride board ---
commit e4e282e1a5c3a7d85da20a185bf57e0515d81e29
Author: Deepti Jaggi <deepti.jaggi@oss.qualcomm.com>

arm64: dts: qcom: Add device tree for Nord Ride board

Add initial device tree for the Qualcomm SA8797P Ride reference board,
which is built on Nord GearVM variant. Configures UART, UFS storage, 
and thermal zones.

> diff --git a/arch/arm64/boot/dts/qcom/nord-ride.dts b/arch/arm64/boot/dts/qcom/nord-ride.dts
> new file mode 100644
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/nord-ride.dts

[ ... ]

> +&scmi3 {
> +	status = "okay";
> +};
> +
> +&scmi11 {
> +	status = "okay";
> +};
> +
> +&scmi15 {
> +	status = "okay";
> +};

[Severity: Low]
Is scmi15 needed here? It doesn't look like there are any devices in this 
board or included dtsi files that consume its protocols. 

Enabling it will cause the kernel to map shared memory and issue SMC calls 
to discover protocols (like power domains, DVFS, resets) that have no 
consumers, which wastes a small amount of memory and boot time.

> +
> +&scmi23 {
> +	status = "okay";
> +};

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260716142605.2398433-1-shengchao.guo@oss.qualcomm.com?part=5

  reply	other threads:[~2026-07-16 14:56 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-16 14:25 [PATCH v6 0/6] Add initial device trees for Nord platform Shawn Guo
2026-07-16 14:25 ` [PATCH v6 1/6] arm64: dts: qcom: Add device tree for Nord SoC series Shawn Guo
2026-07-16 14:44   ` sashiko-bot
2026-07-16 14:25 ` [PATCH v6 2/6] arm64: dts: qcom: Add device tree for Nord GearVM variant Shawn Guo
2026-07-16 17:01   ` Konrad Dybcio
2026-07-16 14:25 ` [PATCH v6 3/6] arm64: dts: qcom: Add device tree for Nord Embedded variant Shawn Guo
2026-07-16 14:43   ` sashiko-bot
2026-07-16 17:01   ` Konrad Dybcio
2026-07-16 14:25 ` [PATCH v6 4/6] dt-bindings: arm: qcom: Document Nord reference boards Shawn Guo
2026-07-16 14:49   ` Bartosz Golaszewski
2026-07-16 14:26 ` [PATCH v6 5/6] arm64: dts: qcom: Add device tree for Nord Ride board Shawn Guo
2026-07-16 14:56   ` sashiko-bot [this message]
2026-07-16 17:14   ` Konrad Dybcio
2026-07-16 14:26 ` [PATCH v6 6/6] arm64: dts: qcom: Add device tree for Nord RRD board Shawn Guo
2026-07-16 17:17   ` Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260716145638.617FD1F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=shengchao.guo@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox