Re: [PATCH v2 3/3] perf/arm-bmu: Add Devicetree support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Implicit declaration of function 'acpi_device_uid' causes a build failure when CONFIG_ACPI is disabled.
--

--- Patch [3]: [PATCH v2 3/3] perf/arm-bmu: Add Devicetree support ---
commit b787d1765a1d6aaa8fa04e23d64224ec5f6d4dc3
Author: Robin Murphy <robin.murphy@arm.com>

perf/arm-bmu: Add Devicetree support

This commit introduces Devicetree support for the ARM Bus Monitor Unit. It
adds the necessary OF match tables and relaxes the Kconfig dependencies so
the driver is no longer strictly tied to ACPI.

> diff --git a/drivers/perf/arm_cspmu/Kconfig b/drivers/perf/arm_cspmu/Kconfig
> --- a/drivers/perf/arm_cspmu/Kconfig
> +++ b/drivers/perf/arm_cspmu/Kconfig
> @@ -30,6 +30,6 @@ config AMPERE_CORESIGHT_PMU_ARCH_SYSTEM_PMU
>  
>  config ARM_BMU
>  	tristate "ARM Bus Monitor Unit"
> -	depends on (ARM64 && ACPI) || COMPILE_TEST
> +	depends on ARM64 || COMPILE_TEST
>  	help

[ ... ]

> diff --git a/drivers/perf/arm_cspmu/arm-bmu.c b/drivers/perf/arm_cspmu/arm-bmu.c
> --- a/drivers/perf/arm_cspmu/arm-bmu.c
> +++ b/drivers/perf/arm_cspmu/arm-bmu.c

[ ... ]

> @@ -406,7 +407,10 @@ static int arm_bmu_probe(struct platform_device *pdev)
>  		.read = arm_bmu_event_read,
>  	};
>  
> -	name = acpi_device_uid(ACPI_COMPANION(dev));
> +	if (has_acpi_companion(dev))
> +		name = acpi_device_uid(ACPI_COMPANION(dev));

[Severity: Low]
Does this cause a build failure in arm_bmu_probe() when CONFIG_ACPI is
disabled?

Since the strict ACPI dependency was removed in Kconfig, building for standard
ARM64 without ACPI is now possible. It appears acpi_device_uid() might not be
stubbed out or available when CONFIG_ACPI is turned off, leading to an implicit
function declaration error during compilation.

> +	else
> +		device_property_read_string(dev, "label", &name);
>  
>  	if (name)

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1784214112.git.robin.murphy@arm.com?part=3