Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Paweł Wiśniewski" <pawel.wis.me@gmail.com>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org
Subject: Re: [RFC PATCH 2/3] dt-bindings: iio: proximity: Add Cytron HC-SR04
Date: Thu, 16 Jul 2026 17:45:18 +0000	[thread overview]
Message-ID: <20260716174519.08FDD1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <bb79ea1b842e062dd47bd1fb31fdd15a9ef76c29.1784221074.git.pawel.wis.me@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit message claims to update the trigger GPIO description, but the patch does not actually modify it.
--

--- Patch [2]: [RFC PATCH 2/3] dt-bindings: iio: proximity: Add Cytron HC-SR04 ---
commit 319a9ebb7272df447013bc727d4e781b829dfcb0
Author: Paweł Wiśniewski <pawel.wis.me@gmail.com>

dt-bindings: iio: proximity: Add Cytron HC-SR04

This commit documents the Cytron HC-SR04 ultrasonic range finder by adding
the cytron,hc-sr04 compatible string and a reference link to the existing
devantech-srf04 binding.

> Add the cytron,hc-sr04 compatible and a reference to the product
> manual. Update the trigger GPIO description to account for the pulse
> durations used by the supported devices.

[Severity: Medium]
The commit message mentions an update to the trigger GPIO description to
account for pulse durations used by the supported devices, but the patch
does not appear to modify the trig-gpios property in the
Documentation/devicetree/bindings/iio/proximity/devantech-srf04.yaml file.
Was this documentation change accidentally omitted from the diff?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1784221074.git.pawel.wis.me@gmail.com?part=2

  reply	other threads:[~2026-07-16 17:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-16 17:35 [RFC PATCH 0/3] iio: proximity: Add Cytron HC-SR04 support Paweł Wiśniewski
2026-07-16 17:35 ` [RFC PATCH 1/3] dt-bindings: vendor-prefixes: Add Cytron Technologies Paweł Wiśniewski
2026-07-16 17:35 ` [RFC PATCH 2/3] dt-bindings: iio: proximity: Add Cytron HC-SR04 Paweł Wiśniewski
2026-07-16 17:45   ` sashiko-bot [this message]
2026-07-16 17:35 ` [RFC PATCH 3/3] iio: proximity: srf04: Add Cytron HC-SR04 support Paweł Wiśniewski
2026-07-16 17:46   ` sashiko-bot
2026-07-16 18:22 ` [RFC PATCH 0/3] iio: proximity: " Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260716174519.08FDD1F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=pawel.wis.me@gmail.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox