Re: [PATCH V17 6/9] iio: imu: inv_icm42607: Add Accelerometer for icm42607

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Missing synchronous suspend on driver unbind leaves hardware sensors active indefinitely.
--

--- Patch [6]: [PATCH V17 6/9] iio: imu: inv_icm42607: Add Accelerometer for icm42607 ---
commit 91f8a7dd90fd683ca51c985841afcdbc30687cd8
Author: Chris Morgan <macromorgan@hotmail.com>

iio: imu: inv_icm42607: Add Accelerometer for icm42607

Add icm42607 accelerometer sensor for icm42607.

> diff --git a/drivers/iio/imu/inv_icm42607/inv_icm42607_core.c b/drivers/iio/imu/inv_icm42607/inv_icm42607_core.c
> index 9613cba025c7b..be082316ed4ba 100644
> --- a/drivers/iio/imu/inv_icm42607/inv_icm42607_core.c
> +++ b/drivers/iio/imu/inv_icm42607/inv_icm42607_core.c
[ ... ]
> @@ -385,6 +564,11 @@ int inv_icm42607_core_probe(struct regmap *regmap,
>  	pm_runtime_set_autosuspend_delay(dev, INV_ICM42607_SUSPEND_DELAY_MS);
>  	pm_runtime_use_autosuspend(dev);
>  
> +	/* Initialize IIO device for Accel */
> +	st->indio_accel = inv_icm42607_accel_init(st);
> +	if (IS_ERR(st->indio_accel))
> +		return PTR_ERR(st->indio_accel);
> +

[Severity: Medium]
Will this leave the hardware sensors active indefinitely if the driver is
unbound?

By registering the IIO device here, the hardware is exposed to userspace. The
driver relies exclusively on devm_pm_runtime_set_active_enabled() for runtime
PM teardown, which calls pm_runtime_disable() and cancels any pending async
autosuspend requests on driver unbind.

Because there is no custom devm action or .remove callback to synchronously put
the device to sleep (e.g., via pm_runtime_force_suspend()), if an autosuspend
is pending during unbind, the chip could remain physically active and continue
to draw power from its regulators. 

Could a synchronous suspend be added on unbind?

>  	return 0;
>  }

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260716182637.24310-1-macroalpha82@gmail.com?part=6