Re: [PATCH v4 2/4] arm64: dts: socfpga: agilex5: Add SoCDK TSN Config2 board

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Missing driver implementation for 'altr,socfpga-stmmac-agilex5-tsn' results in double RGMII delays and broken networking on gmac1.
--

--- Patch [2]: [PATCH v4 2/4] arm64: dts: socfpga: agilex5: Add SoCDK TSN Config2 board ---
commit ff8022a3fa72ba16d067ef0799f67eb51b957387
Author: Nazim Amirul <muhammad.nazim.amirul.nazle.asmade@altera.com>

arm64: dts: socfpga: agilex5: Add SoCDK TSN Config2 board

This commit adds the device tree for the Intel SoCFPGA Agilex5 SoCDK TSN
Config2 board variant, enabling gmac1 as a TSN port. The commit message
states that a board-specific compatible string is used so the driver can
detect the converter and strip the delay bits before configuring the PHY.

> diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_tsn_cfg2.dts b/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_tsn_cfg2.dts
> new file mode 100644
> --- /dev/null
> +++ b/arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_tsn_cfg2.dts

[ ... ]

> +&gmac1 {
> +	status = "okay";
> +	compatible = "altr,socfpga-stmmac-agilex5-tsn",
> +		     "altr,socfpga-stmmac-agilex5",
> +		     "snps,dwxgmac-2.10";
> +	phy-mode = "rgmii-id";

[Severity: Medium]
Is the driver support for "altr,socfpga-stmmac-agilex5-tsn" included in
another patch in this series, or already present in the tree?

If the driver implementation is missing, OF will fall back to
"altr,socfpga-stmmac-agilex5". Since the fallback lacks the board-specific
logic to strip the delay bits from the "rgmii-id" phy-mode before passing it
to the PHY driver, will this cause both the PHY driver and the FPGA soft IP
to independently add clock delays? This double-delaying of the RGMII clocks
could violate RGMII timing specifications and cause broken networking on
the gmac1 interface.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260716021932.20037-1-muhammad.nazim.amirul.nazle.asmade@altera.com?part=2