Re: [PATCH 1/3] dt-bindings: soc: spacemit: k3: add i2s_sysclk, i2s_bclk_factor and i2s1_sysclk_src IDs

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit message incorrectly claims that CLK_MPMU_I2S1_SYSCLK keeps its existing ID of 47, when its actual ID is 34.
--

--- Patch [1]: [PATCH 1/3] dt-bindings: soc: spacemit: k3: add i2s_sysclk, i2s_bclk_factor and i2s1_sysclk_src IDs ---
commit 1a78396155ff5bfe1746259b3e076109f3ecbd38
Author: Troy Mitchell <troy.mitchell@linux.spacemit.com>

dt-bindings: soc: spacemit: k3: add i2s_sysclk, i2s_bclk_factor and i2s1_sysclk_src IDs

This commit adds three new clock IDs for the SpacemiT K3 SoC to expose
clocks related to an I2S topology fix.

> CLK_MPMU_I2S1_SYSCLK keeps its existing ID (47) but will be repointed to
> the real per-instance i2s1 clock in a subsequent patch. No in-tree user
> references this ID so the semantic change is contained.

[Severity: Medium]
Does the commit message reference the correct clock ID here?

Looking at include/dt-bindings/clock/spacemit,k3-clocks.h, 47 is actually
assigned to a different clock:

#define CLK_MPMU_I2S1_SYSCLK     34
...
#define CLK_MPMU_I2S2_SYSCLK     47

Could the commit message be updated to reflect the accurate existing ID for
CLK_MPMU_I2S1_SYSCLK?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260717-k3-clk-fix-i2s-v1-0-e95001a692ee@linux.spacemit.com?part=1