Re: [PATCH v4 12/12] arm64: dts: rockchip: add support for NanoPi M6 board

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Unused OF-graph `port` and `endpoint` nodes are defined inside `rt5616` and `i2s0_8ch`, but they are ignored by the selected sound card driver.
--

--- Patch [12]: [PATCH v4 12/12] arm64: dts: rockchip: add support for NanoPi M6 board ---
commit f3f11c960b7a0aba3e85b29f5c9f9229eadc9524
Author: Joachim Eastwood <joachim.eastwood@gmail.com>

arm64: dts: rockchip: add support for NanoPi M6 board

This commit adds device tree support for the FriendlyElec NanoPi M6 board,
which shares most features with the R6 boards but includes M.2 PCIe slots,
an additional USB 2.0 port, and an RT5616 audio CODEC.

> diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-nanopi-m6v1.dts b/arch/arm64/boot/dts/rockchip/rk3588s-nanopi-m6v1.dts
> new file mode 100644
> index 0000000000000..f981973c96ac0
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3588s-nanopi-m6v1.dts
> @@ -0,0 +1,67 @@
[ ... ]
> +	sound {
> +		compatible = "simple-audio-card";
[ ... ]
> +		simple-audio-card,cpu {
> +			sound-dai = <&i2s0_8ch>;
> +		};
> +
> +		simple-audio-card,codec {
> +			sound-dai = <&rt5616>;
> +		};
> +	};
> +};
> +
> +&i2c7 {
> +	rt5616: codec@1b {
> +		compatible = "realtek,rt5616";
> +		reg = <0x1b>;
> +		clocks = <&cru I2S0_8CH_MCLKOUT_TO_IO>;
> +		clock-names = "mclk";
> +		#sound-dai-cells = <0>;
> +		assigned-clocks = <&cru I2S0_8CH_MCLKOUT_TO_IO>;
> +		assigned-clock-rates = <12288000>;
> +
> +		port {
> +			rt5616_p0: endpoint {
> +				remote-endpoint = <&i2s0_8ch_p0>;
> +			};
> +		};
> +	};
> +};
> +
> +&i2s0_8ch {
> +	port {
> +		i2s0_8ch_p0: endpoint {
> +			dai-format = "i2s";
> +			mclk-fs = <256>;
> +			remote-endpoint = <&rt5616_p0>;
> +		};
> +	};
> +};

[Severity: Low]
Are these OF-graph port and endpoint nodes needed in rt5616 and i2s0_8ch?

Since the sound card uses simple-audio-card with sound-dai phandles to
establish the DAI links, neither simple-audio-card nor the rockchip i2s
driver will parse the ALSA OF-graph routing or properties like mclk-fs
embedded inside these endpoints.

These nodes are typically meant for audio-graph-card, so they appear to be
unused device tree bloat in this configuration.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260717-nanopi-m6-v4-0-b31391a72e41@gmail.com?part=12