From: sashiko-bot@kernel.org
To: "Artem Shimko" <a.shimko.dev@gmail.com>
Cc: robh@kernel.org, devicetree@vger.kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH net-next v2 1/2] dt-bindings: net: add DAPU Telecom DAP8211R(I) PHY binding
Date: Fri, 17 Jul 2026 11:38:42 +0000 [thread overview]
Message-ID: <20260717113843.20D271F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260716113805.593215-2-a.shimko.dev@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The 'dapu' vendor prefix used in 'dapu,tx-inverted-clk' is not documented in vendor-prefixes.yaml.
--
--- Patch [1]: [PATCH net-next v2 1/2] dt-bindings: net: add DAPU Telecom DAP8211R(I) PHY binding ---
commit 05e0cd0742ef4792c4b9865b36c3662e45293902
Author: Artem Shimko <a.shimko.dev@gmail.com>
dt-bindings: net: add DAPU Telecom DAP8211R(I) PHY binding
This commit adds device tree binding documentation for the DAPU Telecom
DAP8211R(I) Gigabit Ethernet PHY, including properties for configuring
TX and RX clock delays and a vendor-specific flag for clock inversion.
> diff --git a/Documentation/devicetree/bindings/net/dapu,dap8211r.yaml b/Documentation/devicetree/bindings/net/dapu,dap8211r.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/dapu,dap8211r.yaml
[ ... ]
> + tx-internal-delay-ps:
> + description:
> + RGMII TX clock delay in picoseconds (0 to maximum).
> + multipleOf: 150
> + maximum: 2250
> + default: 1950
> +
> + dapu,tx-inverted-clk:
[Severity: Low]
Is the dapu vendor prefix documented in vendor-prefixes.yaml?
The dt-schema tool strictly validates all vendor prefixes against the
registry. Because it appears to be missing from
Documentation/devicetree/bindings/vendor-prefixes.yaml, running
make dt_binding_check will result in a schema validation error for an
undocumented vendor prefix.
> + $ref: /schemas/types.yaml#/definitions/flag
> + description:
> + If present, the RGMII TX clock to the MAC is inverted (180 degree
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260716113805.593215-1-a.shimko.dev@gmail.com?part=1
next prev parent reply other threads:[~2026-07-17 11:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-16 11:38 [PATCH net-next v2 0/2] Add DAPU Telecom DAP8211R(I) Gigabit Ethernet PHY driver Artem Shimko
2026-07-16 11:38 ` [PATCH net-next v2 1/2] dt-bindings: net: add DAPU Telecom DAP8211R(I) PHY binding Artem Shimko
2026-07-17 11:38 ` sashiko-bot [this message]
2026-07-16 11:38 ` [PATCH net-next v2 2/2] net: phy: add DAPU Telecom DAP8210R(I) Gigabit Ethernet PHY driver Artem Shimko
2026-07-16 13:01 ` Maxime Chevallier
2026-07-16 16:57 ` Artem Shimko
2026-07-16 13:55 ` Andrew Lunn
2026-07-16 17:01 ` Artem Shimko
2026-07-17 11:38 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260717113843.20D271F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=a.shimko.dev@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox