From: sashiko-bot@kernel.org
To: "Gopikrishna Garmidi" <gopikrishna.garmidi@oss.qualcomm.com>
Cc: devicetree@vger.kernel.org, conor+dt@kernel.org, robh@kernel.org
Subject: Re: [PATCH 4/4] arm64: dts: qcom: Add Glymur QCB
Date: Fri, 17 Jul 2026 12:15:29 +0000 [thread overview]
Message-ID: <20260717121529.9C6281F00A3A@smtp.kernel.org> (raw)
In-Reply-To: <20260717-glymur-qcb-v1-4-aaf1cff84aab@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The device tree references a non-existent label `&remoteproc_soccp`, leading to a dtc compilation failure.
--
--- Patch [4]: [PATCH 4/4] arm64: dts: qcom: Add Glymur QCB ---
commit f3dbd3b60969af3a7e9b8324ba3c25e8c04a5c79
Author: Gopikrishna Garmidi <gopikrishna.garmidi@oss.qualcomm.com>
arm64: dts: qcom: Add Glymur QCB
This commit adds the device tree for the Glymur QCB (Qualcomm Compute Board).
It enables various board components such as clocks, keys, PMIC regulators,
PCIe controllers, WiFi/BT, an embedded controller, and remote processors.
> diff --git a/arch/arm64/boot/dts/qcom/glymur-qcb.dts b/arch/arm64/boot/dts/qcom/glymur-qcb.dts
> new file mode 100644
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/glymur-qcb.dts
[ ... ]
> +&remoteproc_cdsp {
> + firmware-name = "qcom/glymur/cdsp.mbn",
> + "qcom/glymur/cdsp_dtb.mbn";
> +
> + status = "okay";
> +};
> +
> +&remoteproc_soccp {
[Severity: Low]
Does this reference an undefined label? The remoteproc_soccp label does not
appear to be defined in glymur.dtsi or any of the included PMIC files, which
would cause a dtc compilation failure.
> + firmware-name = "qcom/glymur/soccp.mbn",
> + "qcom/glymur/soccp_dtb.mbn";
> +};
> +
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260717-glymur-qcb-v1-0-aaf1cff84aab@oss.qualcomm.com?part=4
next prev parent reply other threads:[~2026-07-17 12:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 11:54 [PATCH 0/4] arm64: dts: qcom: Add Glymur QCB Gopikrishna Garmidi
2026-07-17 11:54 ` [PATCH 1/4] dt-bindings: arm: " Gopikrishna Garmidi
2026-07-17 11:54 ` [PATCH 2/4] dt-bindings: embedded-controller: Add Glymur QCB EC Gopikrishna Garmidi
2026-07-17 12:04 ` Anvesh Jain P
2026-07-17 11:54 ` [PATCH 3/4] firmware: qcom: scm: Allow QSEECOM on the Glymur QCB Gopikrishna Garmidi
2026-07-17 11:54 ` [PATCH 4/4] arm64: dts: qcom: Add " Gopikrishna Garmidi
2026-07-17 12:15 ` sashiko-bot [this message]
2026-07-17 13:24 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260717121529.9C6281F00A3A@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gopikrishna.garmidi@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox