From: sashiko-bot@kernel.org
To: "Ioana Ciornei" <ioana.ciornei@nxp.com>
Cc: Frank.Li@kernel.org, imx@lists.linux.dev, robh@kernel.org,
conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 01/11] arm64: dts: lx2160a: explicitly enable serdes_1 node
Date: Fri, 17 Jul 2026 12:22:24 +0000 [thread overview]
Message-ID: <20260717122225.2D5BB1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260717120635.2118610-2-ioana.ciornei@nxp.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Incomplete device tree update: the patch claims to explicitly enable the `serdes_1` node in "all board DT files" to prepare for an SoC default change, but misses several LX2160A and LX2162A board files.
--
--- Patch [1]: [PATCH v3 01/11] arm64: dts: lx2160a: explicitly enable serdes_1 node ---
commit d3826fcfc7d054169418a33dbec45e352c709bff
Author: Ioana Ciornei <ioana.ciornei@nxp.com>
arm64: dts: lx2160a: explicitly enable serdes_1 node
This commit enables the serdes_1 node in board-specific device tree files.
This change prepares for a subsequent update that will set the default
status of the serdes_1 node to disabled in the main SoC device tree.
> Explicitly enable the serdes_1 node in all board DT files. This is
> needed in order to be able to change the default status of the node to
> "disabled" from the SoC DT file.
[Severity: High]
Does this commit miss updating several other lx2160a and lx2162a board
files?
If the default status in the SoC device tree file is changed to disabled,
it appears boards that rely on serdes_1 for high-speed IO (PCIe,
networking, SATA) might be left without functional interfaces.
Could the following board files also need the serdes_1 node enabled:
- arch/arm64/boot/dts/freescale/fsl-lx2160a-bluebox3.dts
- arch/arm64/boot/dts/freescale/fsl-lx2160a-qds.dts
- arch/arm64/boot/dts/freescale/fsl-lx2162a-qds.dts
- arch/arm64/boot/dts/freescale/fsl-lx2160a-tqmlx2160a.dtsi
Is there a reason these files were omitted from this patch?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260717120635.2118610-1-ioana.ciornei@nxp.com?part=1
next prev parent reply other threads:[~2026-07-17 12:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 12:06 [PATCH v3 00/11] arm64: dts: describe the Lynx 10G and 28G SerDes blocks for Layerscape SoCs Ioana Ciornei
2026-07-17 12:06 ` [PATCH v3 01/11] arm64: dts: lx2160a: explicitly enable serdes_1 node Ioana Ciornei
2026-07-17 12:22 ` sashiko-bot [this message]
2026-07-17 12:49 ` Ioana Ciornei
2026-07-17 12:06 ` [PATCH v3 02/11] arm64: dts: lx2160a: extract the PCIe nodes into a separate dtsi Ioana Ciornei
2026-07-17 12:06 ` [PATCH v3 03/11] arm64: dts: lx2160a: extract the SerDes " Ioana Ciornei
2026-07-17 12:06 ` [PATCH v3 04/11] arm64: dts: lx2160a: extract the PCIe from LX2160A Rev2 into a separate file Ioana Ciornei
2026-07-17 12:06 ` [PATCH v3 05/11] arm64: dts: lx2160a: split the dtsi to avoid delete-property Ioana Ciornei
2026-07-17 12:06 ` [PATCH v3 06/11] arm64: dts: lx2160a: transition to device-specific SerDes compatible strings Ioana Ciornei
2026-07-17 12:06 ` [PATCH v3 07/11] arm64: dts: lx2162a: " Ioana Ciornei
2026-07-17 12:06 ` [PATCH v3 08/11] arm64: dts: ls1028a: describe the Lynx 10G SerDes Ioana Ciornei
2026-07-17 12:06 ` [PATCH v3 09/11] arm64: dts: ls1046a: describe the Lynx 10G SerDes blocks Ioana Ciornei
2026-07-17 12:06 ` [PATCH v3 10/11] arm64: dts: ls208xa: " Ioana Ciornei
2026-07-17 12:06 ` [PATCH v3 11/11] arm64: dts: ls1088a: " Ioana Ciornei
2026-07-17 15:53 ` [PATCH v3 00/11] arm64: dts: describe the Lynx 10G and 28G SerDes blocks for Layerscape SoCs Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260717122225.2D5BB1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=ioana.ciornei@nxp.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox