Re: [PATCH v6 1/3] iio: adc: Fix incorrect reading when datarate changed in single mode

[Jonathan Cameron <jonathan.cameron@oss.qualcomm.com>]

On Tue, 14 Jul 2026 17:56:45 -0700
Jonathan Cameron <jonathan.cameron@oss.qualcomm.com> wrote:

> On Mon, 13 Jul 2026 12:53:49 +0200
> Jakub Szczudło <jakubszczudlo40@gmail.com> wrote:
> 
> > > > +     ret = i2c_master_recv(data->client, (char *)&buffer, sizeof(buffer));    
> > >
> > > In theory this can return short (generally reflects a misbehaving device).
> > >    
> > > > +     if (ret < 0) {
> > > > +             dev_err(&data->client->dev, "I2C read fail: %d\n", ret);
> > > > +             return true;
> > > > +     }    
> > >
> > >         if (ret < sizeof(buffer))
> > >                 return -EIO;
> > >    
> > I have checked the source code for i2c_master_recv and it should
> > return sizeof(buffer)
> > or errno code. Also David and Andy in v4 told me to delete such check.  
> 
> Fair point on it not being needed.  Gah, I get my i2c functions confused.
> Only the multi transfer ones can return partial success.

Turns out that we are both wrong... See Lars reply to my thread tidying
these up universally.  It can return 0 :(
Anyhow, it is very unlikely to do so and hopefully that thread will lead
to us making sure it never does!


Jonathan