From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D65362288CB for ; Sat, 18 Jul 2026 01:40:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784338814; cv=none; b=IDRapZtL4e6aQiDtVydJowfegu+rB079vTZhIQBQpQK3KQ+XupE1V7ZYVxEZGaouHgsx1l1LOtdUE4U7XljF1mOoSdfwQH5D4rICsTHV6qRtCjfqTapvO3Is3iGVGpFnM153MRAwPU+nBw5tIE+gNOtQV272VrKjx1haK19fSjM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784338814; c=relaxed/simple; bh=D80olKqHpoW/xieZjPwzd9en8wqk7u7+sjkbkHWHx1Q=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=k6yfjWcKOeDgpQYicAZBQkrMGkqfPMSS6+SmEcLJncsUdOMR+kRe9HpckoL1YnMFwd/EqNVyaVgE/2YTzoWlhgPR1diieH2pttRSt6HMZR/ZLpW6b59uVJxijslCWEb5/r8+sKd/30aX3UQ6aFWdSEimUqQumSs/peiIC0gCzPw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=MHawPBaU; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=QdigBUJe; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="MHawPBaU"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="QdigBUJe" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66I1IDEV3132401 for ; Sat, 18 Jul 2026 01:40:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= S26ezyycOtOJJs/eO9LtmBbdx8jrwPqoD6H81PFFNZE=; b=MHawPBaUfTnwVOG7 o+SmVpl5eFJPZ2WXCmraE9lW2gZFB1lQYiFwDBVktPQ2i95EZDExtLF5CId4OUCD 5j9m0mnSQs8AeTby4bSwduGrqb92g4OX4ZWWGLNn/t/SHZK83qnZOjFltejMhigE rzEfX551lm6XUptgUjpIOL1SHt+pARg2pSvZKOJ1IpC02V6Jmcp0iFtsnXL0O5JN HmtzNFFLVhp7EY8kPCGxfhRJqb45eC+Hc6pFWwxyPksoMQh3jge5cXLV6lHDeBk0 /sAnTahoFhxWiIK+3vrMXpG6Qc+QXkoO0sMfYRuTQ5nd64GZaosx/pinic1njspz 0BSCVA== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ffyq2r15x-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 18 Jul 2026 01:40:11 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-8423f1fe39eso9352702b3a.1 for ; Fri, 17 Jul 2026 18:40:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784338811; x=1784943611; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=S26ezyycOtOJJs/eO9LtmBbdx8jrwPqoD6H81PFFNZE=; b=QdigBUJekqn9tD7PycUXQ4HNTZR7OkSmZyk4VvszfJyvLZus81mUsG3WeHiLQ436fV o7MOKhAryEaWToWNYyAVo1LMx0J5N11QXkD2wGJ9yis6QCjPPn30rdEFObBMOxVgfigB XyRuQHpkCWPiXRoieWSYbcQfg7ei9Re9+1vHJ3Dy7NXpTC4scEeU/i7ZctxJqc76UmHA XmJFY69gizbNLX/MmoJkElpoRjFeUGonW2Dapai3GewfcEoABfkAJ154ufHn93rXY/yy frxq3UAraI+d/+h/6B1v7tDpHx3KVjgXOg/hUrqxTgFPsrts5o7d3LB0lppKbqAuwlFp GfvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784338811; x=1784943611; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=S26ezyycOtOJJs/eO9LtmBbdx8jrwPqoD6H81PFFNZE=; b=DZle1p5a1YQ/w/NWQkJ0/VvDQPeKFRMCc3JuFI2YOFCYUr2tkiyukCQctcFmnkAF/y fbSTQYmPd5xOZ1WQSPvevO97Y8dCqs6rz/xyJs6HOaniU2rllLz2CODjP4dj+ND/en3O zDqRwGBXJiBceXDtQtukXQ9NByOq2vQZte1n/xqstxKnbBUHFJeLgttSrWbZuFDCEs15 85ZAXH6dxwR4DWzXfQixt8Bw9Un6TZe+N3+3Rn78/Ny+ZCJ+jg4SsOI4STCcon3Fk/3w JNh8UWGmoL0I4IijpUDxs6CQBWu5I1VHKeHvhadItS589VqonUvgG3yQNKkSvT5po26z AS+A== X-Forwarded-Encrypted: i=1; AHgh+RpgmlQQCZl/td6ccsDxpfN3kgjKXKPsxKYhxFZbOyDO+oUsRqbHiJbgyrwqZPWq8KUKFfvYdEZC887f@vger.kernel.org X-Gm-Message-State: AOJu0YwfflaF3n9HZ2Y97mgsk8EwEdc7FANqwO1Gg10QBtvH9wVDlG72 aSDnTtjZQcjym9kZ+dFE5wRmTtfW7WIBMi5hatIyexXIljygbq6FsCPcl0uppD6dzOqWTVsYdvy EVLPcL1eGNeofskRNVlpelMuiNmfgWpE93LqfCAaGMSsE9tMiDeVAUCSzEVTQZhHR X-Gm-Gg: AfdE7cnHL62qM7zgqTMioPZzxVSZz+OR08sUzPiheO+ZKuLI4yJkLwT76cYiXdnrc1E pOBLgU5RDoym73ypSwEycMRCGFNBGMuzCCintVYM6AGGaJzksUv8fSfOJcyEt3XGpv/JAJz8qTC cen1GTYGpZeAUbb68X5H9s3qKB8NnBspqCrlwaVHNpSIdEHuVrEix8OIzwvtPwef4dATaIu3XNA rcZB8GH4e33Zzj/uZzeFPIlUfbOqjiJ+9ybe3VQoOPMnSzlLQH9TUwuZQpPRb8F/Dph4+3gTYoF SMuuIGJ8gqh1VUYBU89BXjGI0ui/Hao3LTE8ahcsPzmC8bUI1jck6Xv5eZ6pSLCDt7LaSv1nJ31 3L8DhHifxNDWHW9nA X-Received: by 2002:a05:6a00:278a:b0:845:d284:9e0a with SMTP id d2e1a72fcca58-84c294d4d65mr5211979b3a.49.1784338811353; Fri, 17 Jul 2026 18:40:11 -0700 (PDT) X-Received: by 2002:a05:6a00:278a:b0:845:d284:9e0a with SMTP id d2e1a72fcca58-84c294d4d65mr5211955b3a.49.1784338810876; Fri, 17 Jul 2026 18:40:10 -0700 (PDT) Received: from jic23-huawei ([50.35.46.84]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84c2adc3466sm2028562b3a.15.2026.07.17.18.40.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 18:40:10 -0700 (PDT) Date: Sat, 18 Jul 2026 02:40:04 +0100 From: Jonathan Cameron To: Andy Shevchenko Cc: Petar Stepanovic , Akhila Kavi , Prasad Bolisetty , David Lechner , Nuno =?UTF-8?B?U8Oh?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Harshit Shah , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/2] iio: adc: add Axiado SARADC driver Message-ID: <20260718023952.5627abec@jic23-huawei> In-Reply-To: References: <20260716-axiado-ax3000-ax3005-saradc-v4-0-810527a9d27f@axiado.com> <20260716-axiado-ax3000-ax3005-saradc-v4-2-810527a9d27f@axiado.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE4MDAxMyBTYWx0ZWRfX0sbIQ67CfgVE 2PiET1Lob4IKgqm8DKtGX57NyaxYlzDTKoAgliIGCSz5ZRP0jHxAu5IwDnFpd0c8rYWo4Lf/XgH Irokz6w4cwhoYacXGSaac/Bjjr1P45g= X-Proofpoint-ORIG-GUID: rtje71MicgDcMDQSNkCd5dI940XXZepW X-Authority-Analysis: v=2.4 cv=WsIb99fv c=1 sm=1 tr=0 ts=6a5ad97c cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=qC1CW/w66vtJz1P9yTJxNA==:17 a=kj9zAlcOel0A:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=QyXUC8HyAAAA:8 a=JNnEj29XURRsWGGOtMsA:9 a=CjuIK1q_8ugA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-GUID: rtje71MicgDcMDQSNkCd5dI940XXZepW X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE4MDAxMyBTYWx0ZWRfX0vvKUu8LrVL+ umn1g9JcD+6RtH81mvPhBq2/ybKJBY9B8yV33gCxtJr5jyqCWIoOLzVfOCGo7BAKIbW3ixAA8EE qwUX6mr0iXmq/ooQnPCGV8hItFI/jPfKNFBQmV4NfKovQ6KCavzXudd7qxt7F7UfUd9YuROOH97 CQlwcIlQLiKF/nmCVW/IWlW7FDBHPZfgsz5kUPQwi5Jq70p+kQ/3sv9B53Babl39d8+YtMU9fX1 01AFlaNu9L/WFdr9keerKvYNU6yq59/FhbWI5YppwlSIyMFuWOskG3DpOSJwX2IEMOWDHn0R1SP uTzf0IxcdIQuqFSVzQkRwmkVPJ772B33Tuo4Vo/4hLC8H7hKwqppFwcfi13CrKh4aHYBd0nhupI kuDwVNAkuwHAZzJ1/U2O73V3W3NejU346r9KdhwRIbZe4pEgExwmQnqyMDH9Ko5i8zBPZLpUfha ZjBgMuUkgtDy8wkHx1w== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-17_07,2026-07-17_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 priorityscore=1501 adultscore=0 malwarescore=0 phishscore=0 spamscore=0 suspectscore=0 clxscore=1015 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607180013 On Fri, 17 Jul 2026 11:34:56 +0300 Andy Shevchenko wrote: > On Thu, Jul 16, 2026 at 10:53:02PM -0700, Petar Stepanovic wrote: > > Add support for the SARADC controller found on Axiado AX3000 and > > AX3005 SoCs. > > > > The driver supports single-shot voltage reads through the IIO > > subsystem. The number of available input channels is selected from > > the SoC match data, allowing AX3000 and AX3005 variants to use the > > same driver. > Andy already commented everywhere I'd have said things, so just a few places where I'd take a different approach to resolving stuff. Thanks, Jonathan > > ... > > > +/* GLOBAL_CTRL register values */ > > +#define AX_SARADC_GLOBAL_CTRL_SAMPLE_16 \ > > + FIELD_PREP(AX_SARADC_GLOBAL_CTRL_SAMPLE_MASK, 0) > > + > > +#define AX_SARADC_GLOBAL_CTRL_MODE_MANUAL \ > > + FIELD_PREP(AX_SARADC_GLOBAL_CTRL_MODE_MASK, 1) > > FIELD_PREP_CONST() in both cases. > For this second one I'd rather see defines for the values the field takes and then FIELD_PREP only used inline. #define AX_SARADC_GLOBAL_CTL_MODE_something 0 #define AX_SARADC_GLOBAL_CTL_MODE_MANUAL 1 To me that acts as clearer documentation of what is going on at the point of the write. Similar applies for the SAMPLE_MASK field where I'd define the value 0 with a name then have the FIELD_PREP() inline. > ... > > > +#define AX_SARADC_MANUAL_CTRL_EN(ch) \ > > + (AX_SARADC_MANUAL_CTRL_ENABLE | \ > > + FIELD_PREP(AX_SARADC_MANUAL_CTRL_CH_SEL_MASK, ch)) > > Missing parentheses for ch. Also wrong indentation of the second line, missing > one space. > I wonder if it would be more readable to just push that inline rather than having this define at all.