Re: [PATCH net-next v9 08/12] of: property: fw_devlink: Add support for "pcs-handle"

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Adding `pcs-handle` to `fw_devlink` supplier bindings defeats the dynamic 'late PCS provider attach' and hotplug logic in `phylink`.
--

--- Patch [8]: [PATCH net-next v9 08/12] of: property: fw_devlink: Add support for "pcs-handle" ---
commit f6fc253d355d434feccac1a9dee68ebce25d5fe8
Author: Christian Marangi <ansuelsmth@gmail.com>

of: property: fw_devlink: Add support for "pcs-handle"

This commit adds support for parsing the "pcs-handle" binding, allowing
fw_devlink to enforce device dependencies with Ethernet ports.

> diff --git a/drivers/of/property.c b/drivers/of/property.c
> index 72cf12907de03..91c3e3931fa6e 100644
> --- a/drivers/of/property.c
> +++ b/drivers/of/property.c

[ ... ]

> @@ -1571,6 +1572,7 @@ static const struct supplier_bindings of_supplier_bindings[] = {
>  	{ .parse_prop = parse_interrupts, },
>  	{ .parse_prop = parse_interrupt_map, },
>  	{ .parse_prop = parse_access_controllers, },
> +	{ .parse_prop = parse_pcs_handle, },

[Severity: High]
Does enforcing a strict supplier-consumer dependency here conflict with the
dynamic hotplug and late-attach logic in phylink?

If fw_devlink creates a managed device link for pcs-handle, it enforces strict
boot ordering. This prevents the MAC from probing before the PCS, which blocks
phylink's late-attach feature.

Additionally, because fw_devlink applies DL_FLAG_AUTOREMOVE_CONSUMER, unloading
the PCS module would cause the driver core to unceremoniously unbind the MAC
driver and remove the network interface. This circumvents phylink's graceful
link down handling via phylink_release_pcs().

Since similar properties like phy-handle are intentionally omitted from
of_supplier_bindings to allow for dynamic PHY/PCS presence, should pcs-handle
also be excluded to preserve these phylink features?

>  	{ .parse_prop = parse_regulators, },
>  	{ .parse_prop = parse_gpio, },
>  	{ .parse_prop = parse_gpios, },

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260717065448.1498335-1-ansuelsmth@gmail.com?part=8