Re: [PATCH 1/5] dt-bindings: usb: parade,ps8830: Add parade,disable-usb4 property

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] The device tree binding violates OS-agnostic design principles by describing Linux-specific software behavior and internal driver states instead of hardware properties.
- [Low] The commit message contains a malformed and non-standard patch trailer 'Assisted-by: Grok(xAI):4.3'.
--

--- Patch [1]: [PATCH 1/5] dt-bindings: usb: parade,ps8830: Add parade,disable-usb4 property ---
commit 3e93d13f3a0b964fe4e6611bd03b162fa75d29a3
Author: Jens Glathe <jens.glathe@oldschoolsolutions.biz>

dt-bindings: usb: parade,ps8830: Add parade,disable-usb4 property

This commit documents a new optional boolean property parade,disable-usb4
for the parade,ps8830 device tree binding, which disables USB4 mode.

>     Assisted-by: Grok(xAI):4.3
>     Signed-off-by: Jens Glathe <jens.glathe@oldschoolsolutions.biz>

[Severity: Low]
Does the Assisted-by trailer conform to the standard patch submission
guidelines? 

This tag is non-standard, and it is missing the expected Name <email>
formatting. Could this cause issues with automated patch parsing tools?

> diff --git a/Documentation/devicetree/bindings/usb/parade,ps8830.yaml b/Documentation/devicetree/bindings/usb/parade,ps8830.yaml
> index eaeab1c01a594..44242907461eb 100644
> --- a/Documentation/devicetree/bindings/usb/parade,ps8830.yaml
> +++ b/Documentation/devicetree/bindings/usb/parade,ps8830.yaml

[ ... ]

> @@ -66,6 +66,12 @@ properties:
>            Sideband Use (SBU) AUX lines endpoint to the Type-C connector for the purpose of
>            handling altmode muxing and orientation switching.
>  
> +  parade,disable-usb4:
> +    type: boolean
> +    description:
> +      When present, the retimer rejects USB4 mode (returns -EOPNOTSUPP).
> +      This forces the Type-C stack to fall back to USB3 + DP Alternate Mode.

[Severity: Low]
Should the description for parade,disable-usb4 focus on the physical
hardware state or board constraints rather than Linux-specific driver
behavior? 

Mentioning internal software details like returning -EOPNOTSUPP and the
Type-C stack seems to go against the principle that device tree bindings
should be OS-agnostic. Could this be rephrased to describe the hardware
limitations instead?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260718-ps883x-disable-usb4-v1-0-cec86d0b909e@oldschoolsolutions.biz?part=1