From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0FED26AC3 for ; Sun, 19 Jul 2026 00:15:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784420118; cv=none; b=dXrKAdlU8ZRmcK+mQu2wCu9OaU3RRi/dctbAF5XZuaHHrD3dGRrY8Xz9OMVqTJe98PYICfTJ1pLOJU/BgVY4pRumScQhxffyx42J9b4dfcI4e6Neo8yMxeZ+OvHuOnQt4i2ueGh2k12K9iS8wn0F3FMjjRT8YhUVrTVECm9PLik= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784420118; c=relaxed/simple; bh=u1fp1alkBNst/d1DzrEnNRW68x049gphSMGWlVawCIo=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=WyP1qlZgsnfNkqVuI9PD7Q60l4c8TEY95L6sblvxBsmgqHPCEpl94wcuPO8NoryImRlz7M08HpAUVf63VY5uU/T7Z28jFAxGSxg9AUlY7jIlVLUjevMhydMhaV4hWvAo2vkMtcMUNfgEX6/HMn6hh1CVWos0ziQhAa+QXParJzs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=RUCLgyIR; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=M3egmu6u; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="RUCLgyIR"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="M3egmu6u" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66IN2DU21585163 for ; Sun, 19 Jul 2026 00:15:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= jVtBejOk/fS9XQZvzarHu+foBgQblzV41Qics6xtFZ4=; b=RUCLgyIRYVts9/2s 6+y7DuyqiVzp5l33JMD9gJqSwGPG7bHiCuiHZjgRPIPWzkOTf6ajAA4RJvvihwxl 3V91JAmPf+SRgPdoZJYk43iIHaVuBgzrB1TTK8MDCv6igWSxhIurQjK6tLiibFBY zKEGYPVVN5wtSIBl89y4jf/vXkSkqzsJcQyomvkI5rvADW+/eJ2UosjX5C5qjvsW WmZR/+A9euUPR/oCJRPG54xCRZ/j/yx0zrQSlEq2UuthZsdBZbU1xeMEuKlSbFGG 7+5LJCsI2V5nJwELHJcMpbskCC1yZQx3+SrGHyLrwtMzqiFLs943HQCwu0bR06M0 QdJgTw== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fg2nhhsfk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sun, 19 Jul 2026 00:15:14 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-c88cfe287e1so5230511a12.1 for ; Sat, 18 Jul 2026 17:15:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784420114; x=1785024914; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=jVtBejOk/fS9XQZvzarHu+foBgQblzV41Qics6xtFZ4=; b=M3egmu6uR/v4t7VVo0x6s3uFM2hUuzGlDyu24kqAAJgo0eSGFxXrDSChjIq46P8O04 hBZIxq4zWc299PtJvfUVvzBIrYUckCuOZrEVAPCPXYc7h7iq5+GevmpcG6toUMPEzyyr 1Mvp/46Q+sVhaT/+a/FOeMgnisjFpn+e6iLgAiEfLpbBpS/G6+4eQDBuokvy3FemSavF 2DoB55JmwCkcJfQ5ncUQGW+/qIrgbd9UuncPy6REZVOOH9alqXCFRMhIiaNEdiG1aC1A 7W9ADVeHKTZNY5y4CyvW/GC7ys50lYkw6IUv0OJrGEvjl1zxSrAZi+TLbxeF2g2v7eJu trIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784420114; x=1785024914; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=jVtBejOk/fS9XQZvzarHu+foBgQblzV41Qics6xtFZ4=; b=XBexAJCOw3KB68aV9MKfVcic7ar14iD0rMiYr4U18hYNm0kK5FITymLzmPDXy3Q0gN Xo/13ONz0mkeavgjG44AjA8Ex3uzx6SghEf2Cs4Ps6dz5Tmdoj/URf8uHIz1f723mGQC XdmmMbTJSDStNvJQFRpDe4xtP8oE+q9Q/wmslJA5gUx9OjTvLqNiyIH/GdO+20QlM3WB 97eHbYUXFurOX0uL8UpeaApNvSHoJCwyccZPfq0ekiJqP1CnmaXOYPNgptG3d9wZoLiD Qu0WbV7M8MPdEfLM98vLicuRb4q2VPw5whiHNgD/xpTd+Hgotyjpu9o5z/GZjknPLf3S 7l6A== X-Forwarded-Encrypted: i=1; AHgh+Roz1obqB5zmB7vuxWYQeb+1m86ZPF7J6YJc+zagbE6ynRoUBVV9pUOU6zZJ6jSkQ1lfUDpSp8WPo4xj@vger.kernel.org X-Gm-Message-State: AOJu0YxUnhkxqlx2XVTY26Ub4m5kwmxQEW0wCJdoeHNeztasdtz/2l5X Bqc7qIAu6HNbFpC7kMp+IdUL6Xwt51/NpDvdl2IkboXlloGbF2RhDY8IspV0HqzMHjyANw5XZ1H IC6KkcJGGRTPkbFjdXzx0JIT9LW4JemmAu/z/+hbvG6GLRECSTnJu5EYTbkaHD996 X-Gm-Gg: AfdE7cn2wtnpjwiGWg1FZEr2TIyHiFDfvVBN1eNY3ODE98AyCId3pRdrPREsAbTC7mO HEOWykEFjLOBCBQad2FPRcbi8kCyEAHrOAJEo+NEk5FGqgN6grZWuAZgvTt8vo3qb8Yp7XYri0C xB/y6+LpBfu0Ck9BZS2GSAXno/OutGJVZy1nq7Ztm0/+in3pAlJTgs5aGMqPxuxZ/SROrkQOVy1 wFZGsQzmXi9UyHdkULYElveG/+2h6Zta5bYyVdMb4raruxFOLzFAgtQbTGrFYkt4rQ0ou1kqefr IwdYVR2PobGozWDIjLrO66xalSyKM3+pB6skp/C1uQ8JmAIy+Xkyw3mk9i6kHa80GEs33hlB/3T 52siwE/cH1AFP2vuc X-Received: by 2002:a05:6a00:9283:b0:848:2f74:1d5f with SMTP id d2e1a72fcca58-84c29568665mr7946957b3a.69.1784420114218; Sat, 18 Jul 2026 17:15:14 -0700 (PDT) X-Received: by 2002:a05:6a00:9283:b0:848:2f74:1d5f with SMTP id d2e1a72fcca58-84c29568665mr7946915b3a.69.1784420113746; Sat, 18 Jul 2026 17:15:13 -0700 (PDT) Received: from jic23-huawei ([50.35.46.84]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84c2ad89d0csm3466351b3a.6.2026.07.18.17.15.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Jul 2026 17:15:13 -0700 (PDT) Date: Sun, 19 Jul 2026 01:15:07 +0100 From: Jonathan Cameron To: Rodrigo Alencar via B4 Relay Cc: rodrigo.alencar@analog.com, Michael Auchter , linux@analog.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, Michael Hennerich , David Lechner , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Kees Cook , "Gustavo A. R. Silva" , sashiko-bot@kernel.org, Maxwell Doose , Joshua Crofts , Andy Shevchenko Subject: Re: [PATCH v8 0/8] New features for the AD5686 IIO driver Message-ID: <20260719011454.10239afd@jic23-huawei> In-Reply-To: <20260716-ad5686-new-features-v8-0-ebb0051af5e5@analog.com> References: <20260716-ad5686-new-features-v8-0-ebb0051af5e5@analog.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=Le0MLDfi c=1 sm=1 tr=0 ts=6a5c1712 cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=qC1CW/w66vtJz1P9yTJxNA==:17 a=kj9zAlcOel0A:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=VwQbUJbxAAAA:8 a=gAnH3GRIAAAA:8 a=evLihkQWVGAqolPEgxMA:9 a=CjuIK1q_8ugA:10 a=3WC7DwWrALyhR5TkjVHa:22 X-Proofpoint-GUID: IeD26PhNV4yVCueloBgWwYl_V9fttGA6 X-Proofpoint-ORIG-GUID: IeD26PhNV4yVCueloBgWwYl_V9fttGA6 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE5MDAwMCBTYWx0ZWRfX4sDpF72e/uNK lsyZEgTDrq+YMrcr53QQ+DyAYg3O3rjqkJShr4LyDnT3nb9LCWbt+AXXIl7P2ubsi3Z5jAEjKWC uHj06fcH5bPhaNrt2FiW0oTHZbCFbe4kjSo+c5peJZu0adwgdf2yydUDMJWwqrGPyyBQC5KCXJN TrfO97mKxqUdc5lsRIScsrRRM9khpmnrYdmUgsjwanmhVD9kQK/zOHvArzirAm0esj8//9jEoiY 3L17U7JWjLT3yWcEFDfAl7rtLydFQZwGNOakWc/CFp9bndu8LsRjjXjB2CdijbqAjtu08c0qBKm 5qw+nryePuIY01cL1I5RF/RNf3QLmzcjWez9j5Wd5R3Y6vxNs/bcpZBHwhUaknM9OoJvbhUt7Mh CBLMsv10BEW2szpgoKX+BtdGfcMFIeXwO+x2cNgVfGCfBWXccaLHRHLsfuWE+ez5vFkxas+FrNS 18rVeOXiTEwBUFSvFSA== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE5MDAwMCBTYWx0ZWRfX6zTe23OmxSVc AGjz8klUS0MUDYLoeBoxC91zo1Hy8znkJ5zPp/edLYot8w9lULK4hwZ6lovst8CRnwliCd9i8xa 14XlJ4hHxQpp575tsTKU7phGv/LvRrE= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-18_07,2026-07-17_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 clxscore=1015 adultscore=0 phishscore=0 bulkscore=0 impostorscore=0 priorityscore=1501 malwarescore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607190000 On Thu, 16 Jul 2026 13:14:16 +0100 Rodrigo Alencar via B4 Relay wrote: > This is the second series of three on updating the AD5686 driver. > > Initially, a big patch series was sent: > https://lore.kernel.org/r/20260422-ad5313r-iio-support-v1-0-ed7dca001d1b@analog.com > > Then, the first patch series added fixes and cleanups: > https://lore.kernel.org/linux-iio/20260524-ad5686-fixes-v7-0-b6bf395d08bd@analog.com/ > > This one is introducing new features: > - Consume optional reset and correct power supplies; > - LDAC GPIO handling (active-low, held low when unused); > - SPI bus sync() implementation for batching multiple transfers; > - Triggered buffer support, leveraging LDAC and sync() to flush > all channel writes atomically; > - Gain control support through the scale property. > > Signed-off-by: Rodrigo Alencar Applied 2-8 but with tweaks as called out. Pushed out as testing, please check I didn't mess it up. For 1, hopefully I'll get some time this week to put out a set adding the defensive check in the i2c layer. That API is just too weird today for my liking. Jonathan > --- > Changes in v8: > - Add nul-check for chip_info match data. > - Update comments/commit text and other minor changes. > - Link to v7: https://lore.kernel.org/r/20260710-ad5686-new-features-v7-0-1bcc8c280e4d@analog.com > > Changes in v7: > - Fix return value check of i2c_transfer(). > - Amend refactoring of command/data macros. > - Link to v6: https://lore.kernel.org/r/20260705-ad5686-new-features-v6-0-269594c7aae5@analog.com > > Changes in v6: > - Refactor command/data macros in favor of FIELD_PREP() > - Link to v5: https://lore.kernel.org/r/20260628-ad5686-new-features-v5-0-577caadbf7c0@analog.com > > Changes in v5: > - Create auxiliary handler for the triggered buffer. > - Do not allow modification of double_scale in case gain_gpio is not set. > - Link to v4: https://lore.kernel.org/r/20260623-ad5686-new-features-v4-0-28962a57db0f@analog.com > > Changes in v4: > - Replace anyof+const for enum in dt-bindings. > - Address some sashiko's comments. > - Use guard(mutex)() in trigger handler and other misc changes. > - Link to v3: https://lore.kernel.org/r/20260616-ad5686-new-features-v3-0-f829fb7e9262@analog.com > > Changes in v3: > - Add range-double property. > - Acquire reset control after power-up delay. > - Include cleanup.h and use guard(mutex)() in read_raw(). > - Link to v2: https://lore.kernel.org/r/20260609-ad5686-new-features-v2-0-70b423f5c76d@analog.com > > Changes in v2: > - Get reset control deasserted. > - Update entire spi_transfer struct rather than individual fields. > - Replace udelay() for fsleep() in probe(). > - Minor changes addressing further feedback. > - Link to v1: https://lore.kernel.org/r/20260602-ad5686-new-features-v1-0-691e01883d27@analog.com > > --- > Rodrigo Alencar (8): > iio: dac: ad5696: properly check i2c_transfer() return value > iio: dac: ad5686: missing NULL check on match data > iio: dac: ad5686: refactor command/data macros > iio: dac: ad5686: introduce sync operation > iio: dac: ad5686: implement new sync() op for the spi bus > iio: dac: ad5686: read_raw/write_raw: use guard(mutex)() > iio: dac: ad5686: add triggered buffer support > iio: dac: ad5686: add gain control support > > drivers/iio/dac/Kconfig | 2 + > drivers/iio/dac/ad5686-spi.c | 142 +++++++++++++++++++++------- > drivers/iio/dac/ad5686.c | 217 +++++++++++++++++++++++++++++++++++++++---- > drivers/iio/dac/ad5686.h | 52 ++++++++--- > drivers/iio/dac/ad5696-i2c.c | 18 ++-- > 5 files changed, 355 insertions(+), 76 deletions(-) > --- > base-commit: 4c0ecdbdc0d87570f74e656e21d56bae1ab6a8f1 > change-id: 20260602-ad5686-new-features-e116c04bddb9 > > Best regards,