From: sashiko-bot@kernel.org
To: "Vishnu Saini" <vishnu.saini@oss.qualcomm.com>
Cc: robh@kernel.org, devicetree@vger.kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 1/3] arm64: dts: qcom: lemans-evk: Add LVDS display overlay
Date: Sun, 19 Jul 2026 18:17:52 +0000 [thread overview]
Message-ID: <20260719181752.B583C1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260719-lvds-support-v1-1-1f1aca3213ba@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [High] The `lontium,lt9211c` compatible string has no matching driver or fallback, preventing the bridge from probing.
- [Low] The `panel-lvds` node violates the `panel-lvds.yaml` DT schema bindings regarding the compatible string and the use of the `ports` node.
--
--- Patch [1]: [PATCH 1/3] arm64: dts: qcom: lemans-evk: Add LVDS display overlay ---
commit 2607cce8051c05162f525ecd61797d0bdba55e07
Author: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
arm64: dts: qcom: lemans-evk: Add LVDS display overlay
This patch adds a DTBO overlay for the Lemans EVK IFP mezzanine to support
LVDS display output. It wires up a Lontium LT9211C DSI-to-LVDS bridge and a
BOE 1080p LVDS panel.
> diff --git a/arch/arm64/boot/dts/qcom/lemans-evk-lvds-boe,dv215fhm-r01.dtso b/arch/arm64/boot/dts/qcom/lemans-evk-lvds-boe,dv215fhm-r01.dtso
> new file mode 100644
> index 0000000000000..17c20e86e950b
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/lemans-evk-lvds-boe,dv215fhm-r01.dtso
[ ... ]
> + panel_lvds: panel-lvds {
> + compatible = "boe,dv215fhm-r01", "panel-lvds";
[Severity: Low]
Will this cause dtbs_check validation failures? The panel-lvds.yaml schema
does not currently document the "boe,dv215fhm-r01" compatible string.
> + data-mapping = "vesa-24";
> + width-mm = <476>;
> + height-mm = <268>;
> + power-supply = <&lcd_disp_bias>;
> + status = "okay";
> +
> + panel-timing {
[ ... ]
> + };
> +
> + ports {
[Severity: Low]
Additionally, while the Linux DRM driver successfully parses the ports node
for dual-link LVDS at runtime, the panel-lvds.yaml schema restricts the
node to a strict single port. Will this trigger unevaluatedProperties warnings
during schema compilation?
> + #address-cells = <1>;
> + #size-cells = <0>;
[ ... ]
> +&i2c1 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&qup_i2c1_default>;
> + status = "okay";
> +
> + lt9211c_codec: lvds-bridge@2d {
> + compatible = "lontium,lt9211c";
[Severity: High]
Is there a matching driver or fallback for this compatible string?
The existing driver in drivers/gpu/drm/bridge/lontium-lt9211.c only binds to
"lontium,lt9211". Without a valid fallback here, will the bridge fail to
probe and leave the LVDS display dead?
> + reg = <0x2d>;
> + reset-gpios = <&tlmm 37 GPIO_ACTIVE_HIGH>;
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260719-lvds-support-v1-0-1f1aca3213ba@oss.qualcomm.com?part=1
next prev parent reply other threads:[~2026-07-19 18:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-19 18:05 [PATCH 0/3] arm64: dts: qcom: Add LVDS display overlays for lemans, monaco and rb3gen2 Vishnu Saini
2026-07-19 18:05 ` [PATCH 1/3] arm64: dts: qcom: lemans-evk: Add LVDS display overlay Vishnu Saini
2026-07-19 18:17 ` sashiko-bot [this message]
2026-07-19 18:05 ` [PATCH 2/3] arm64: dts: qcom: monaco-evk: " Vishnu Saini
2026-07-19 18:15 ` sashiko-bot
2026-07-19 18:05 ` [PATCH 3/3] arm64: dts: qcom: qcs6490-rb3gen2: " Vishnu Saini
2026-07-19 18:17 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260719181752.B583C1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vishnu.saini@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox