Re: [PATCH v4 1/3] clk: composite: Export devm composite pdata helper

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Commit message inaccuracy: Non-devm pdata composite helpers are not actually exported, contradicting the commit message.
--

--- Patch [1]: [PATCH v4 1/3] clk: composite: Export devm composite pdata helper ---
commit 796e54251258da0c70103cd9b568babacd07c5ed
Author: Jia Wang <wangjia@ultrarisc.com>

clk: composite: Export devm composite pdata helper

Allow modular clock drivers to use devm_clk_hw_register_composite_pdata()
by exporting the helper.

> The non-devm composite helpers are already available to modules. Export
> this devm variant as well so users do not need to open-code devres
> cleanup.

[Severity: Medium]
Is this description accurate regarding the non-devm pdata helpers?

Looking at drivers/clk/clk-composite.c, the non-devm helper doesn't appear
to have an export annotation:

struct clk_hw *clk_hw_register_composite_pdata(struct device *dev,
			const char *name,
			const struct clk_parent_data *parent_data,
			int num_parents,
			struct clk_hw *mux_hw, const struct clk_ops *mux_ops,
			struct clk_hw *rate_hw, const struct clk_ops *rate_ops,
			struct clk_hw *gate_hw, const struct clk_ops *gate_ops,
			unsigned long flags)
{
	return __clk_hw_register_composite(dev, name, NULL, parent_data,
					   num_parents, mux_hw, mux_ops,
					   rate_hw, rate_ops, gate_hw,
					   gate_ops, flags);
}

Could the commit message be updated, or should the non-devm variants be
exported as well to match the description?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260720-ultrarisc-clock-v4-0-fe639d63bbac@ultrarisc.com?part=1