From: Jonathan Cameron <jonathan.cameron@oss.qualcomm.com>
To: Jorijn van der Graaf <jorijnvdgraaf@catcrafts.net>
Cc: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Siratul Islam" <siratul.islam@linux.dev>,
"Luca Weiss" <luca.weiss@fairphone.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] iio: magnetometer: add support for QST QMC6308
Date: Mon, 20 Jul 2026 02:00:29 +0100 [thread overview]
Message-ID: <20260720020029.18e959c3@jic23-huawei> (raw)
In-Reply-To: <20260715204657.46657-1-jorijnvdgraaf@catcrafts.net>
On Wed, 15 Jul 2026 22:46:57 +0200
Jorijn van der Graaf <jorijnvdgraaf@catcrafts.net> wrote:
> On Tue, 14 Jul 2026 23:21:18 +0200, Uwe Kleine-König wrote:
> > On Tue, Jul 14, 2026 at 10:28:42PM +0200, Jorijn van der Graaf wrote:
> > > +#include <linux/i2c.h>
> > > +#include <linux/mod_devicetable.h>
> >
> > Please drop the include of <linux/mod_devicetable.h>. You need
> > i2c_device_id and of_device_id, both are provided by <linux/i2c.h>.
>
> Will do in v2, thanks,
> Jorijn
Hi Jorijn,
Welcome to IIO.
Small process thing. Don't send replies like this. They add
noise to the mailing list and we all have far too many emails
to read through! Instead put a note in the changelog for v2.
Basically we'll assume you have accepted any feedback you don't
reply to.
Note I send this email at least once a week to someone new!
Thanks,
Jonathan
next prev parent reply other threads:[~2026-07-20 1:00 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-14 20:28 [PATCH 0/2] iio: magnetometer: add support for QST QMC6308 Jorijn van der Graaf
2026-07-14 20:28 ` [PATCH 1/2] dt-bindings: iio: magnetometer: add " Jorijn van der Graaf
2026-07-15 18:32 ` Siratul Islam
2026-07-15 20:46 ` Jorijn van der Graaf
2026-07-15 22:16 ` Siratul Islam
2026-07-16 14:18 ` Jorijn van der Graaf
2026-07-20 0:58 ` Jonathan Cameron
2026-07-20 1:09 ` Jonathan Cameron
2026-07-14 20:28 ` [PATCH 2/2] iio: magnetometer: add support for " Jorijn van der Graaf
2026-07-14 20:38 ` sashiko-bot
2026-07-14 21:21 ` Uwe Kleine-König
2026-07-15 20:46 ` Jorijn van der Graaf
2026-07-20 1:00 ` Jonathan Cameron [this message]
2026-07-16 9:52 ` Siratul Islam
2026-07-16 10:11 ` Siratul Islam
2026-07-16 14:18 ` Jorijn van der Graaf
2026-07-16 14:45 ` Siratul Islam
2026-07-16 19:06 ` Siratul Islam
2026-07-20 1:06 ` Jonathan Cameron
2026-07-20 6:01 ` Siratul Islam
2026-07-20 1:38 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260720020029.18e959c3@jic23-huawei \
--to=jonathan.cameron@oss.qualcomm.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jorijnvdgraaf@catcrafts.net \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
--cc=siratul.islam@linux.dev \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox