Re: [PATCH 1/2] dt-bindings: media: add ITE IT6625/IT6626 HDMI bridge binding

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing schema constraint for 'bus-type' across IT6625 and IT6626 variants.
--

--- Patch [1]: [PATCH 1/2] dt-bindings: media: add ITE IT6625/IT6626 HDMI bridge binding ---
commit 0c73fe488fb2529ba9b003362cc54eefde27f9f8
Author: Hermes Wu <Hermes.wu@ite.com.tw>

dt-bindings: media: add ITE IT6625/IT6626 HDMI bridge binding

This commit documents the devicetree binding for the ITE IT6625 and IT6626
HDMI to MIPI CSI-2 bridge devices. It defines the required properties,
including up to two selectable CSI-2 output ports.

> diff --git a/Documentation/devicetree/bindings/media/i2c/ite,it6625.yaml b/Documentation/devicetree/bindings/media/i2c/ite,it6625.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/ite,it6625.yaml
[ ... ]
> +      port@0:
[ ... ]
> +        properties:
> +          endpoint:
[ ... ]
> +            properties:
> +              data-lanes:
> +                minItems: 1
> +                maxItems: 4
> +
> +              bus-type:
> +                enum:
> +                  - 1 # MEDIA_BUS_TYPE_CSI2_CPHY
> +                  - 4 # MEDIA_BUS_TYPE_CSI2_DPHY

[Severity: Low]
The commit message mentions that IT6625 only supports D-PHY, while IT6626
supports C/D-PHY. Does this unconditional enum allow C-PHY to pass schema
validation for the IT6625? Should there be an allOf / if-then conditional
block restricting the bus-type to 4 for the ite,it6625 compatible?

Additionally, since the IT6626 can use either PHY, should bus-type be made
a required property when ite,it6626 is used to avoid ambiguous driver
configurations?

> +
> +              clock-noncontinuous: true
> +              link-frequencies: true
[ ... ]
> +      port@1:
[ ... ]
> +        properties:
> +          endpoint:
[ ... ]
> +            properties:
> +              data-lanes:
> +                minItems: 1
> +                maxItems: 4
> +
> +              bus-type:
> +                enum:
> +                  - 1 # MEDIA_BUS_TYPE_CSI2_CPHY
> +                  - 4 # MEDIA_BUS_TYPE_CSI2_DPHY

[Severity: Low]
Would the same constraints and required properties for bus-type need to be
applied here for port@1?

> +
> +              clock-noncontinuous: true
> +              link-frequencies: true
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260720-upstream-it6625-it6626-v1-0-475912f74459@ite.com.tw?part=1