Re: [PATCH 1/4] dt-bindings: sound: fsl,imx-asrc: update port binding to support multiple pairs

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The newly added example causes `make dt_binding_check` to fail due to a device tree node merge conflict.
--

--- Patch [1]: [PATCH 1/4] dt-bindings: sound: fsl,imx-asrc: update port binding to support multiple pairs ---
commit 45674653b1eb8f9efa969b217b62dc494801eaf3
Author: Shengjiu Wang <shengjiu.wang@nxp.com>

dt-bindings: sound: fsl,imx-asrc: update port binding to support multiple pairs

The i.MX ASRC hardware supports up to three conversion pairs. This commit
updates the binding to add a ports container that enumerates three named
sub-ports, while deprecating the old single port property and ensuring
both cannot be used simultaneously.

> diff --git a/Documentation/devicetree/bindings/sound/fsl,imx-asrc.yaml b/Documentation/devicetree/bindings/sound/fsl,imx-asrc.yaml
> index 608defc93c1e9..18d252722aa8e 100644
> --- a/Documentation/devicetree/bindings/sound/fsl,imx-asrc.yaml
> +++ b/Documentation/devicetree/bindings/sound/fsl,imx-asrc.yaml

[ ... ]

> @@ -188,3 +212,57 @@ examples:
>              };
>         };
>      };
> +
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    #include <dt-bindings/clock/imx6qdl-clock.h>
> +    asrc1: asrc@2034000 {

[Severity: Low]
Does this identical node name and unit address cause a node merge conflict
during make dt_binding_check?

The dt-extract-example tool processes the examples array by concatenating all
items into a single device tree root node. Because this new example uses the
exact same node name and unit address (asrc@2034000) as the preceding example,
the Device Tree Compiler merges them together.

The resulting merged asrc@2034000 node ends up containing both the port
property from the first example and the ports property from this second
example. 

This violates the newly added schema constraint preventing port and ports
from both being required at the same time, which causes validation to fail.

Could a different unit address be used for this second example to prevent
the nodes from being merged?

> +        compatible = "fsl,imx53-asrc";
> +        reg = <0x02034000 0x4000>;
> +        interrupts = <0 50 IRQ_TYPE_LEVEL_HIGH>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260720095450.1618747-1-shengjiu.wang@oss.nxp.com?part=1