Re: [PATCH v7 09/10] arm64: dts: qcom: shikra: Enable WiFi/BT on SoMs

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Critical] Incorrect voltage regulators are assigned to the WCN3988 PMU `vddio-supply` and WiFi `vdd-0.8-cx-mx-supply` rails, leading to severe under- and over-voltage risks.
--

--- Patch [9]: [PATCH v7 09/10] arm64: dts: qcom: shikra: Enable WiFi/BT on SoMs ---
commit 7b0dbc06276bce121a4707dc81431f18358503c8
Author: Komal Bajaj <komal.bajaj@oss.qualcomm.com>

arm64: dts: qcom: shikra: Enable WiFi/BT on SoMs

Shikra SoM cards include WCN3988 WiFi/Bluetooth chip, with supplies provided
by on-card PMICs. Enable both interfaces and provide the required supply and
calibration data.

> diff --git a/arch/arm64/boot/dts/qcom/shikra-cqm-som.dtsi b/arch/arm64/boot/dts/qcom/shikra-cqm-som.dtsi
> --- a/arch/arm64/boot/dts/qcom/shikra-cqm-som.dtsi
> +++ b/arch/arm64/boot/dts/qcom/shikra-cqm-som.dtsi

[ ... ]

> @@ -27,6 +31,42 @@ key-volume-up {
>  			linux,can-disable;
>  		};
>  	};
> +
> +	wcn3988-pmu {
> +		compatible = "qcom,wcn3988-pmu";
> +
> +		pinctrl-0 = <&sw_ctrl_default>;
> +		pinctrl-names = "default";
> +
> +		swctrl-gpios = <&tlmm 88 GPIO_ACTIVE_HIGH>;
> +
> +		vddio-supply = <&pm4125_l7>;

[Severity: Critical]
Does this code assign a 0.664V regulator to a 1.8V supply in wcn3988-pmu?

The WCN3988 PMU's vddio-supply expects 1.8V, but pm4125_l7 is typically 0.664V.
Could this regression cause an undervoltage that prevents digital I/O
communication?

> +		vddxo-supply = <&pm4125_l13>;
> +		vddrf-supply = <&pm4125_l10>;

[ ... ]

> diff --git a/arch/arm64/boot/dts/qcom/shikra-iqs-som.dtsi b/arch/arm64/boot/dts/qcom/shikra-iqs-som.dtsi
> --- a/arch/arm64/boot/dts/qcom/shikra-iqs-som.dtsi
> +++ b/arch/arm64/boot/dts/qcom/shikra-iqs-som.dtsi

[ ... ]

> +&wifi {
> +	vdd-0.8-cx-mx-supply = <&pm8150_s4>;

[Severity: Critical]
Does this assignment cause an overvoltage regression in the wifi node?

The vdd-0.8-cx-mx-supply requires ~0.8V, but pm8150_s4 has a 1.08V to 2.04V
range (typically 1.8V), which could lead to hardware damage on the IQS SoM.

> +	vdd-1.8-xo-supply = <&vreg_pmu_xo>;
> +	vdd-1.3-rfa-supply = <&vreg_pmu_rf>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260720-shikra-dt-m1-v7-0-7dc99100c6dd@oss.qualcomm.com?part=9